From 37cae4704b3d037eb9f1f689fd0070d3ed3ed6fe Mon Sep 17 00:00:00 2001 From: Josh Goebel Date: Sat, 20 Feb 2016 23:18:02 -0500 Subject: [PATCH] remove beginNoLogo, do not deprecate --- src/Arduboy.cpp | 9 +++------ src/Arduboy.h | 17 +++++++---------- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/src/Arduboy.cpp b/src/Arduboy.cpp index 9dab6b4..81e906a 100644 --- a/src/Arduboy.cpp +++ b/src/Arduboy.cpp @@ -24,6 +24,9 @@ void Arduboy::start() // deprecated begin(); } +// functions called here should be public so users can create their +// own init functions if they need different behavior than `begin` +// provides by default void Arduboy::begin() { boot(); // raw hardware @@ -38,12 +41,6 @@ void Arduboy::begin() audio.begin(); } -void Arduboy::beginNoLogo() // deprecated -{ - boot(); - audio.begin(); -} - void Arduboy::flashlight() { // sendLCDCommand(OLED_ALL_PIXELS_ON); // smaller than allPixelsOn() diff --git a/src/Arduboy.h b/src/Arduboy.h index b679b30..1165683 100644 --- a/src/Arduboy.h +++ b/src/Arduboy.h @@ -44,21 +44,18 @@ public: /// Initialize hardware, boot logo, boot utilities, etc. void begin(); - /// Init hardware, no logo, no boot utilities. + /// Init just hardware, no logo, no boot utilities. /** - * If you really want this functionality going foward we recommend - * just call `boot()` directly, then do any other custom init you - * desire before passing control into your main sketch. - * * Look at the source for `begin()` and just rip out what you do not - * need and start there. + * need and start there. Calling just `boot()` might work also + * depending on your requirements. * - * The minimum functionality required is currently: + * The minimum recommended `begin` replacement: * - * boot() // raw hardware init (from core) - * audio.begin() // if you need audio + * arduboy.boot() // raw hardware init + * arduboy.audio.begin() // if you need audio */ - void beginNoLogo() __attribute__ ((deprecated("use boot() + custom code instead"))); + // void boot(); // defined in core.cpp void start() __attribute__ ((deprecated("use begin() instead")));