fleg
/
Arduboy2
mirror of https://github.com/MLXXXp/Arduboy2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug in drawPixel asm

This commit is contained in:
Pharap 2017-06-14 19:31:54 +01:00
parent 342186281a
commit 427c1d53f2
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Arduboy2.cpp
View File

@ -299,24 +299,25 @@ void Arduboy2Base::drawPixel(int16_t x, int16_t y, uint8_t color)
// the above math can also be rewritten more simply as; // the above math can also be rewritten more simply as;
// row_offset = (y * WIDTH/8) & ~0b01111111 + (uint8_t)x; // row_offset = (y * WIDTH/8) & ~0b01111111 + (uint8_t)x;
// which is what the below assembler does // which is what the below assembler does
asm volatile( asm volatile(
"mul %[width_offset],%[y]\n" "mul %[width_offset], %A[y]\n"
"movw %[row_offset], r0\n" "movw %[row_offset], r0\n"
"andi %A[row_offset], 0x80\n" // row_offset &= (~0b01111111); "andi %A[row_offset], 0x80\n" // row_offset &= (~0b01111111);
"clr __zero_reg__\n" "clr __zero_reg__\n"
"add %A[row_offset], %[x]\n" "add %A[row_offset], %[x]\n"
// mask for only 0-7 // mask for only 0-7
"andi %[y], 0x07\n" "andi %A[y], 0x07\n"
// Z += y // Z += y
"add r30, %[y]\n" "add r30, %A[y]\n"
"adc r31, __zero_reg__\n" "adc r31, __zero_reg__\n"
// load correct bitshift from program RAM // load correct bitshift from program RAM
"lpm %[bit], Z\n" "lpm %[bit], Z\n"
: [row_offset] "=x&" (row_offset), // upper register (ANDI) : [row_offset] "=x&" (row_offset), // upper register (ANDI)
[bit] "=r" (bit) [bit] "=r" (bit),
[y] "+d" (y) // upper register (ANDI), must be writable
: [width_offset] "r" ((uint8_t)(WIDTH/8)), : [width_offset] "r" ((uint8_t)(WIDTH/8)),
[x] "r" ((uint8_t)x), [x] "r" ((uint8_t)x),
[y] "d" ((uint8_t)y), // upper register (ANDI)
"z" (bitshift_left) "z" (bitshift_left)
:); :);