From 93adfa41f57977e3f80bafdbb7dfc9f26adcd931 Mon Sep 17 00:00:00 2001 From: Pharap <2933055+Pharap@users.noreply.github.com> Date: Tue, 21 Apr 2020 03:57:27 +0100 Subject: [PATCH] Make 'writeUnitName' const-correct Without this, an attempt to pass a string literal or an array of `const` `char` as an argument will create a warning: * `warning: invalid conversion from 'const char*' to 'char*' [-fpermissive]` * `warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]` In a standard C++ environment, these warnings would be compiler errors. --- src/Arduboy2.cpp | 2 +- src/Arduboy2.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Arduboy2.cpp b/src/Arduboy2.cpp index 8f4cb07..a920dd0 100644 --- a/src/Arduboy2.cpp +++ b/src/Arduboy2.cpp @@ -1096,7 +1096,7 @@ uint8_t Arduboy2Base::readUnitName(char* name) return dest; } -void Arduboy2Base::writeUnitName(char* name) +void Arduboy2Base::writeUnitName(const char* name) { bool done = false; uint8_t dest = EEPROM_UNIT_NAME; diff --git a/src/Arduboy2.h b/src/Arduboy2.h index 032a089..17302e7 100644 --- a/src/Arduboy2.h +++ b/src/Arduboy2.h @@ -1169,7 +1169,7 @@ class Arduboy2Base : public Arduboy2Core * * \see readUnitName() writeUnitID() Arduboy2::bootLogoExtra() */ - void writeUnitName(char* name); + void writeUnitName(const char* name); /** \brief * Read the "Show Boot Logo" flag in system EEPROM.