From 0ab179a701e27c83e99aa86266ebd5e075309bf6 Mon Sep 17 00:00:00 2001
From: vk7js <58905135+vk7js@users.noreply.github.com>
Date: Fri, 13 May 2022 15:07:22 +1000
Subject: [PATCH] use constant for string length for prior menu name and value.
 Also reset prior value if name changes.

---
 openrtx/src/ui/ui_menu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/openrtx/src/ui/ui_menu.c b/openrtx/src/ui/ui_menu.c
index d4407df5..34697aee 100644
--- a/openrtx/src/ui/ui_menu.c
+++ b/openrtx/src/ui/ui_menu.c
@@ -34,8 +34,8 @@
 /* UI main screen helper functions, their implementation is in "ui_main.c" */
 extern void _ui_drawMainBottom();
 
-static char priorSelectedMenuName[21] = "\0";
-static char priorSelectedMenuValue[21] = "\0";
+static char priorSelectedMenuName[MAX_ENTRY_LEN] = "\0";
+static char priorSelectedMenuValue[MAX_ENTRY_LEN] = "\0";
 
 const char *display_timer_values[] =
 {
@@ -70,6 +70,8 @@ bool DidSelectedMenuItemChange(char* menuName, char* menuValue)
 		strcpy(priorSelectedMenuName, menuName);
 		if (menuValue)
 			strcpy(priorSelectedMenuValue, menuValue);
+		else
+			*priorSelectedMenuValue = '\0'; // reset it since we've changed menu item.
 
 		return true;
 	}