From 40ff9baa47da39dbaab83e0ebbbbc2cd7cc4d814 Mon Sep 17 00:00:00 2001
From: Silvano Seva <silseva@fastwebnet.it>
Date: Fri, 15 Aug 2025 19:56:50 +0200
Subject: [PATCH] ui: gps: added indication for no GPS device detected

Clearly show on UI the case when no GPS receiver has been detected in the
hardware. Previously either the "GPS off" or "No fix" strings where shown
also in case of no GPS, causing ambiguity.
---
 openrtx/include/ui/EnglishStrings.h | 3 ++-
 openrtx/include/ui/SpanishStrings.h | 3 ++-
 openrtx/include/ui/ui_strings.h     | 1 +
 openrtx/src/ui/default/ui_menu.c    | 5 ++++-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/openrtx/include/ui/EnglishStrings.h b/openrtx/include/ui/EnglishStrings.h
index 621a6fa9..26df3fcb 100644
--- a/openrtx/include/ui/EnglishStrings.h
+++ b/openrtx/include/ui/EnglishStrings.h
@@ -94,6 +94,7 @@ const stringsTable_t englishStrings =
     .broadcast         = "ALL",
     .radioSettings     = "Radio Settings",
     .frequencyOffset   = "Frequency Offset",
-    .macroLatching     = "Macro Latching"
+    .macroLatching     = "Macro Latching",
+    .noGps             = "No GPS",
 };
 #endif  // ENGLISHSTRINGS_H
diff --git a/openrtx/include/ui/SpanishStrings.h b/openrtx/include/ui/SpanishStrings.h
index f5198e0f..22fe17bf 100644
--- a/openrtx/include/ui/SpanishStrings.h
+++ b/openrtx/include/ui/SpanishStrings.h
@@ -95,6 +95,7 @@ const stringsTable_t spanishStrings =
     .broadcast         = "TODOS",
     .radioSettings     = "Ajustes de Radio",
     .frequencyOffset   = "Offset de frecuencia",
-    .macroLatching     = "Macro Latching"
+    .macroLatching     = "Macro Latching",
+    .noGps             = "Ningún GPS",
 };
 #endif  // SPANISHSTRINGS_H
diff --git a/openrtx/include/ui/ui_strings.h b/openrtx/include/ui/ui_strings.h
index 4a80e150..9389bcbb 100644
--- a/openrtx/include/ui/ui_strings.h
+++ b/openrtx/include/ui/ui_strings.h
@@ -99,6 +99,7 @@ typedef struct
     const char* radioSettings;
     const char* frequencyOffset;
     const char* macroLatching;
+    const char* noGps;
 }
 stringsTable_t;
 
diff --git a/openrtx/src/ui/default/ui_menu.c b/openrtx/src/ui/default/ui_menu.c
index 1cb54c8a..973f5dcd 100644
--- a/openrtx/src/ui/default/ui_menu.c
+++ b/openrtx/src/ui/default/ui_menu.c
@@ -638,7 +638,10 @@ void _ui_drawMenuGPS()
               color_white, currentLanguage->gps);
     point_t fix_pos = {layout.line2_pos.x, CONFIG_SCREEN_HEIGHT * 2 / 5};
     // Print GPS status, if no fix, hide details
-    if(!last_state.settings.gps_enabled)
+    if(!last_state.gpsDetected)
+        gfx_print(fix_pos, layout.line3_large_font, TEXT_ALIGN_CENTER,
+                  color_white, currentLanguage->noGps);
+    else if(!last_state.settings.gps_enabled)
         gfx_print(fix_pos, layout.line3_large_font, TEXT_ALIGN_CENTER,
                   color_white, currentLanguage->gpsOff);
     else if (last_state.gps_data.fix_quality == 0)