mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

node: Log read buffer if not empty

This commit is contained in:
Alexis Sellier 2023-02-07 21:13:29 +01:00
parent f66ecd4ece
commit 054655d79b
No known key found for this signature in database
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
radicle-node/src/wire/protocol.rs
View File

@ -26,6 +26,7 @@ use radicle::storage::WriteStorage;
use crate::crypto::Signer;
use crate::service::reactor::{Fetch, Io};
use crate::service::{routing, session, DisconnectReason, Message, Service};
use crate::wire;
use crate::wire::{Decode, Encode};
use crate::worker::{Task, TaskResult};
use crate::Link;
@ -479,11 +480,22 @@ where
// Buffer is empty, or message isn't complete.
break;
}
Err(err) => {
// TODO(cloudhead): Include error in reason.
log::error!(target: "wire", "Invalid message from {}: {err}", id);
Err(e) => {
log::error!(target: "wire", "Invalid message from {id}: {e}");
let mut leftover = if let wire::Error::UnknownMessageType(ty) = e {
ty.to_ne_bytes().to_vec()
} else {
vec![]
};
leftover.extend(self.read_queue.drain(..));
if !leftover.is_empty() {
log::debug!(target: "wire", "Dropping read buffer with `{:?}`", &leftover);
}
self.disconnect(
fd,
// TODO(cloudhead): Include error in reason.
DisconnectReason::Session(session::Error::Misbehavior),
);
break;