From 0bb0fe8f258194cae4bc4177c36f177f20c2d467 Mon Sep 17 00:00:00 2001
From: cloudhead <cloudhead@radicle.xyz>
Date: Mon, 4 Nov 2024 14:34:30 +0100
Subject: [PATCH] cob: Fix compatibility with certain old patches

We were rejecting patches that were once valid, due to a rule that was
added some time ago. Move that rule one level up, in the write path,
instead of in the read path.
---
 radicle/src/cob/patch.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/radicle/src/cob/patch.rs b/radicle/src/cob/patch.rs
index 8755dc89..f3fc8abb 100644
--- a/radicle/src/cob/patch.rs
+++ b/radicle/src/cob/patch.rs
@@ -864,9 +864,6 @@ impl Patch {
                     // If the revision was redacted concurrently, there's nothing to do.
                     return Ok(());
                 };
-                if summary.is_none() && verdict.is_none() {
-                    return Err(Error::EmptyReview);
-                }
                 if let Some(rev) = rev {
                     // Insert a review if there isn't already one. Otherwise we just ignore
                     // this operation
@@ -2173,6 +2170,9 @@ where
         labels: Vec<Label>,
         signer: &G,
     ) -> Result<ReviewId, Error> {
+        if verdict.is_none() && summary.is_none() {
+            return Err(Error::EmptyReview);
+        }
         self.transaction("Review", signer, |tx| {
             tx.review(revision, verdict, summary, labels)
         })