mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle/src/git: additionally specify pruneTags for remote 

Ensure that, when adding a remote, `pruneTags` is set to `false` so
that tags are not pruned when fetching from a remote's namespace.
This commit is contained in:
Fintan Halpenny 2025-09-06 11:25:14 +03:00
parent 646d4360e7
commit 11e8b89b20
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/radicle/src/git.rs
View File

@ -597,7 +597,16 @@ pub fn configure_repository(repo: &git2::Repository) -> Result<(), git2::Error>
/// fetch = +refs/heads/*:refs/remotes/<name>/*
/// fetch = +refs/tags/*:refs/remotes/<name>/tags/*
/// tagOpt = --no-tags
/// pruneTags = false
/// ```
///
/// Because of the `+refs/tags/*:…` refspec, set:
/// 1. `pruneTags = false` to ensure that `git` does not delete tags because
/// the remote does not have them. Tags for a Radicle repository are
/// synthesised by canonical refs and thus, the `rad` remote will handle
/// fetching them.
/// 2. `tagOpt = --no-tags` to ensure that tags are not fetched and stored
/// under `refs/tags`, again, because these are fetched by the `rad` remote.
pub fn configure_remote<'r>(
repo: &'r git2::Repository,
name: &str,
@ -613,11 +622,9 @@ pub fn configure_remote<'r>(
let tags = format!("+refs/tags/*:refs/remotes/{name}/tags/*");
repo.remote_add_fetch(name, &tags)?;
// Because of the above, if we don't set `--no-tags` then the tags will be
// fetched into `refs/tags` as well. We don't want to do this *unless* it's
// the `rad` remote, which will have the canonical tags
if name != (*rad::REMOTE_NAME).as_str() {
let mut config = repo.config()?;
config.set_bool(&format!("remote.{name}.pruneTags"), false)?;
config.set_str(&format!("remote.{name}.tagOpt"), "--no-tags")?;
}