mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cli: fix `issue` command asking for passphrase 

Only require `signer` when doing a write operation.
This commit is contained in:
Christopher Fredén 2024-02-05 16:55:08 +01:00 committed by cloudhead
parent 50833d88d9
commit 13d5b4f620
No known key found for this signature in database
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
radicle-cli/src/commands/issue.rs
View File

@ -432,7 +432,6 @@ impl Args for Options {
pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> { pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
let profile = ctx.profile()?; let profile = ctx.profile()?;
let signer = term::signer(&profile)?;
let rid = if let Some(rid) = options.repo { let rid = if let Some(rid) = options.repo {
rid rid
} else { } else {
@ -458,6 +457,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
title, title,
description, description,
} => { } => {
let signer = term::signer(&profile)?;
let issue = edit(&mut issues, &repo, id, title, description, &signer)?; let issue = edit(&mut issues, &repo, id, title, description, &signer)?;
if !options.quiet { if !options.quiet {
term::issue::show(&issue, issue.id(), Format::Header, &profile)?; term::issue::show(&issue, issue.id(), Format::Header, &profile)?;
@ -469,6 +469,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
labels, labels,
assignees, assignees,
} => { } => {
let signer = term::signer(&profile)?;
let issue = issues.create(title, description, &labels, &assignees, [], &signer)?; let issue = issues.create(title, description, &labels, &assignees, [], &signer)?;
if !options.quiet { if !options.quiet {
term::issue::show(&issue, issue.id(), Format::Header, &profile)?; term::issue::show(&issue, issue.id(), Format::Header, &profile)?;
@ -479,6 +480,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
message, message,
reply_to, reply_to,
} => { } => {
let signer = term::signer(&profile)?;
let issue_id = id.resolve::<cob::ObjectId>(&repo.backend)?; let issue_id = id.resolve::<cob::ObjectId>(&repo.backend)?;
let mut issue = issues.get_mut(&issue_id)?; let mut issue = issues.get_mut(&issue_id)?;
let (body, reply_to) = prompt_comment(message, reply_to, &issue, &repo)?; let (body, reply_to) = prompt_comment(message, reply_to, &issue, &repo)?;
@ -503,6 +505,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
} }
} }
Operation::State { id, state } => { Operation::State { id, state } => {
let signer = term::signer(&profile)?;
let id = id.resolve(&repo.backend)?; let id = id.resolve(&repo.backend)?;
let mut issue = issues.get_mut(&id)?; let mut issue = issues.get_mut(&id)?;
issue.lifecycle(state, &signer)?; issue.lifecycle(state, &signer)?;
@ -514,6 +517,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
} => { } => {
let id = id.resolve(&repo.backend)?; let id = id.resolve(&repo.backend)?;
if let Ok(mut issue) = issues.get_mut(&id) { if let Ok(mut issue) = issues.get_mut(&id) {
let signer = term::signer(&profile)?;
let comment_id = comment_id.unwrap_or_else(|| { let comment_id = comment_id.unwrap_or_else(|| {
let (comment_id, _) = term::io::comment_select(&issue).unwrap(); let (comment_id, _) = term::io::comment_select(&issue).unwrap();
*comment_id *comment_id
@ -527,6 +531,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
ref labels, ref labels,
ref assignees, ref assignees,
} => { } => {
let signer = term::signer(&profile)?;
open( open(
title.clone(), title.clone(),
description.clone(), description.clone(),
@ -542,6 +547,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
id, id,
opts: AssignOptions { add, delete }, opts: AssignOptions { add, delete },
} => { } => {
let signer = term::signer(&profile)?;
let id = id.resolve(&repo.backend)?; let id = id.resolve(&repo.backend)?;
let Ok(mut issue) = issues.get_mut(&id) else { let Ok(mut issue) = issues.get_mut(&id) else {
anyhow::bail!("Issue `{id}` not found"); anyhow::bail!("Issue `{id}` not found");
@ -558,6 +564,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
id, id,
opts: LabelOptions { add, delete }, opts: LabelOptions { add, delete },
} => { } => {
let signer = term::signer(&profile)?;
let id = id.resolve(&repo.backend)?; let id = id.resolve(&repo.backend)?;
let Ok(mut issue) = issues.get_mut(&id) else { let Ok(mut issue) = issues.get_mut(&id) else {
anyhow::bail!("Issue `{id}` not found"); anyhow::bail!("Issue `{id}` not found");
@ -574,6 +581,7 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
list(issues, &assigned, &state, &profile)?; list(issues, &assigned, &state, &profile)?;
} }
Operation::Delete { id } => { Operation::Delete { id } => {
let signer = term::signer(&profile)?;
let id = id.resolve(&repo.backend)?; let id = id.resolve(&repo.backend)?;
issues.remove(&id, &signer)?; issues.remove(&id, &signer)?;
} }