From 258d2d35e4363fdc650fca88f6839fd0ed019458 Mon Sep 17 00:00:00 2001
From: Alexis Sellier <self@cloudhead.io>
Date: Mon, 30 Jan 2023 12:27:32 +0100
Subject: [PATCH] Move function to trait

---
 radicle/src/storage/git.rs | 72 ++++++++++++++++++--------------------
 1 file changed, 34 insertions(+), 38 deletions(-)

diff --git a/radicle/src/storage/git.rs b/radicle/src/storage/git.rs
index 19e8cb8e..d90d11c9 100644
--- a/radicle/src/storage/git.rs
+++ b/radicle/src/storage/git.rs
@@ -244,43 +244,6 @@ impl Repository {
         Ok((repo, oid))
     }
 
-    pub fn verify(&self) -> Result<(), VerifyError> {
-        let mut remotes: HashMap<RemoteId, Refs> = self
-            .remotes()?
-            .map(|remote| {
-                let (id, remote) = remote?;
-                Ok((id, remote.refs.into()))
-            })
-            .collect::<Result<_, VerifyError>>()?;
-
-        for entry in self.namespaced_references()? {
-            let (remote_id, refname, oid) = entry?;
-            let remote = remotes
-                .get_mut(&remote_id)
-                .ok_or(VerifyError::InvalidRemote(remote_id))?;
-            let refname = RefString::from(refname);
-            let signed_oid = remote
-                .remove(&refname)
-                .ok_or_else(|| VerifyError::UnknownRef(remote_id, refname.clone()))?;
-
-            if oid != signed_oid {
-                return Err(VerifyError::InvalidRefTarget(remote_id, refname, *oid));
-            }
-        }
-
-        for (remote, refs) in remotes.into_iter() {
-            // The refs that are left in the map, are ones that were signed, but are not
-            // in the repository.
-            if let Some((name, _)) = refs.into_iter().next() {
-                return Err(VerifyError::MissingRef(remote, name));
-            }
-            // Verify identity history of remote.
-            self.identity(&remote)?.verified(self.id)?;
-        }
-
-        Ok(())
-    }
-
     pub fn inspect(&self) -> Result<(), Error> {
         for r in self.backend.references()? {
             let r = r?;
@@ -467,7 +430,40 @@ impl ReadRepository for Repository {
     }
 
     fn verify(&self) -> Result<(), VerifyError> {
-        Repository::verify(self)
+        let mut remotes: HashMap<RemoteId, Refs> = self
+            .remotes()?
+            .map(|remote| {
+                let (id, remote) = remote?;
+                Ok((id, remote.refs.into()))
+            })
+            .collect::<Result<_, VerifyError>>()?;
+
+        for entry in self.namespaced_references()? {
+            let (remote_id, refname, oid) = entry?;
+            let remote = remotes
+                .get_mut(&remote_id)
+                .ok_or(VerifyError::InvalidRemote(remote_id))?;
+            let refname = RefString::from(refname);
+            let signed_oid = remote
+                .remove(&refname)
+                .ok_or_else(|| VerifyError::UnknownRef(remote_id, refname.clone()))?;
+
+            if oid != signed_oid {
+                return Err(VerifyError::InvalidRefTarget(remote_id, refname, *oid));
+            }
+        }
+
+        for (remote, refs) in remotes.into_iter() {
+            // The refs that are left in the map, are ones that were signed, but are not
+            // in the repository.
+            if let Some((name, _)) = refs.into_iter().next() {
+                return Err(VerifyError::MissingRef(remote, name));
+            }
+            // Verify identity history of remote.
+            self.identity(&remote)?.verified(self.id)?;
+        }
+
+        Ok(())
     }
 
     fn reference(