From 2b9a014243b83c5955e529291c242727d363600d Mon Sep 17 00:00:00 2001 From: cloudhead Date: Mon, 1 Apr 2024 16:32:30 +0200 Subject: [PATCH] node: Small changes and note around initial state --- radicle-node/src/service.rs | 2 +- radicle-node/src/wire/protocol.rs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/radicle-node/src/service.rs b/radicle-node/src/service.rs index 2c35ee18..cbfeabf2 100644 --- a/radicle-node/src/service.rs +++ b/radicle-node/src/service.rs @@ -1653,7 +1653,7 @@ where } } (session::State::Attempted { .. } | session::State::Initial, msg) => { - error!(target: "service", "Received {:?} from connecting peer {}", msg, peer.id); + debug!(target: "service", "Ignoring unexpected message {:?} from connecting peer {}", msg, peer.id); } (session::State::Disconnected { .. }, msg) => { debug!(target: "service", "Ignoring {:?} from disconnected peer {}", msg, peer.id); diff --git a/radicle-node/src/wire/protocol.rs b/radicle-node/src/wire/protocol.rs index c88b5e6e..2cb63e2b 100644 --- a/radicle-node/src/wire/protocol.rs +++ b/radicle-node/src/wire/protocol.rs @@ -905,6 +905,8 @@ where target: "wire", "Attempt to connect to already connected peer {node_id}" ); + // FIXME: The problem here is the session will stay in "initial" state, + // because it can't transition to attempted. continue; } self.service.attempted(node_id, addr.clone());