mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle/git/canonical: Actually use qualified refs 

Some tests actually do not use qualified patterns. The removed lines
*should* not compile because the `qualified_pattern!` proc macro
*should* validate the string literals at compile time, but it contains
a bug and actually does not assert well-formedness of qualified
refspec patterns. Rectify.
This commit is contained in:
Lorenz Leutgeb 2025-10-05 02:26:21 +02:00 committed by Fintan Halpenny
parent ee041d8d06
commit 30908dcf48
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
crates/radicle/src/git/canonical/rules.rs
View File

@ -894,27 +894,33 @@ mod tests {
#[test] #[test]
fn test_order() { fn test_order() {
assert!( assert!(
pattern(qualified_pattern!("a/b/c/d/*")) < pattern(qualified_pattern!("*/x")), pattern(qualified_pattern!("refs/heads/a/b/c/d/*"))
< pattern(qualified_pattern!("refs/heads/*/x")),
"example 1" "example 1"
); );
assert!( assert!(
pattern(qualified_pattern!("a")) < pattern(qualified_pattern!("*")), pattern(qualified_pattern!("refs/heads/a"))
< pattern(qualified_pattern!("refs/heads/*")),
"example 2.a" "example 2.a"
); );
assert!( assert!(
pattern(qualified_pattern!("abc")) < pattern(qualified_pattern!("a*")), pattern(qualified_pattern!("refs/heads/abc"))
< pattern(qualified_pattern!("refs/heads/a*")),
"example 2.a" "example 2.a"
); );
assert!( assert!(
pattern(qualified_pattern!("a/b/*")) < pattern(qualified_pattern!("a/*/c")), pattern(qualified_pattern!("refs/heads/a/b/*"))
< pattern(qualified_pattern!("refs/heads/a/*/c")),
"example 2.a" "example 2.a"
); );
assert!( assert!(
pattern(qualified_pattern!("aa*")) < pattern(qualified_pattern!("a*")), pattern(qualified_pattern!("refs/heads/aa*"))
< pattern(qualified_pattern!("refs/heads/a*")),
"example 2.b.A" "example 2.b.A"
); );
assert!( assert!(
pattern(qualified_pattern!("a*b")) < pattern(qualified_pattern!("a*")), pattern(qualified_pattern!("refs/heads/a*b"))
< pattern(qualified_pattern!("refs/heads/a*")),
"example 2.b.B" "example 2.b.B"
); );
@ -930,17 +936,17 @@ mod tests {
let pattern09 = pattern(qualified_pattern!("refs/foos/*")); let pattern09 = pattern(qualified_pattern!("refs/foos/*"));
let pattern10 = pattern(qualified_pattern!("a")); let pattern10 = pattern(qualified_pattern!("refs/heads/a"));
let pattern11 = pattern(qualified_pattern!("b")); let pattern11 = pattern(qualified_pattern!("refs/heads/b"));
let pattern12 = pattern(qualified_pattern!("a/*")); let pattern12 = pattern(qualified_pattern!("refs/heads/a/*"));
let pattern13 = pattern(qualified_pattern!("b/*")); let pattern13 = pattern(qualified_pattern!("refs/heads/b/*"));
let pattern14 = pattern(qualified_pattern!("a/*/ab")); let pattern14 = pattern(qualified_pattern!("refs/heads/a/*/ab"));
let pattern15 = pattern(qualified_pattern!("a/*/a")); let pattern15 = pattern(qualified_pattern!("refs/heads/a/*/a"));
let pattern16 = pattern(qualified_pattern!("a/*/b")); let pattern16 = pattern(qualified_pattern!("refs/heads/a/*/b"));
let pattern17 = pattern(qualified_pattern!("a/*/a")); let pattern17 = pattern(qualified_pattern!("refs/heads/a/*/a"));
// Test priority for path specificity // Test priority for path specificity
assert!( assert!(