mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle/cob/identity: Test terminal states 

The identity evaluation rewrite changed how revision redactions are
handled. Instead of removing the revision entirely, it explicitly
transitions the revision to `State::Redacted`.

Add a test to cover two redaction scenarios:
 - Attempting to redact a revision that has already been `Accepted`.
 - Attempting to redact a revision that has already been `Rejected`.
This commit is contained in:
Adrian Duke 2026-05-22 14:24:33 +01:00 committed by Fintan Halpenny
parent 489360d0e5
commit 39972b0c46
1 changed files with 106 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

106
crates/radicle/src/cob/identity.rs
View File

@ -1907,6 +1907,112 @@ mod test {
);
}
#[test]
fn test_identity_cannot_redact_terminal_states() {
let network = Network::default();
let alice = &network.alice;
let bob = &network.bob;
let mut alice_identity = Identity::load_mut(&*alice.repo, &alice.signer).unwrap();
let mut alice_doc = alice_identity.doc().clone().edit();
alice_doc.delegate(bob.signer.public_key().into());
let a1 = alice_identity
.update(
cob::Title::new("Add Bob").unwrap(),
"",
&alice_doc.verified().unwrap(),
)
.unwrap();
bob.repo.fetch(alice);
let mut bob_identity = Identity::load_mut(&*bob.repo, &bob.signer).unwrap();
bob_identity.accept(&a1).unwrap();
alice.repo.fetch(bob);
alice_identity.reload().unwrap();
let mut alice_doc2 = alice_identity.doc().clone().edit();
alice_doc2.visibility = Visibility::private([]);
let a2 = alice_identity
.update(
cob::Title::new("A2").unwrap(),
"",
&alice_doc2.verified().unwrap(),
)
.unwrap();
bob.repo.fetch(alice);
bob_identity.reload().unwrap();
bob_identity.accept(&a2).unwrap();
alice_identity.redact(a2).unwrap();
alice.repo.fetch(bob);
alice_identity.reload().unwrap();
assert_eq!(
alice_identity.revision(&a2).unwrap().state,
State::Redacted(RedactedBy::Author)
);
let mut alice_doc3 = alice_identity.doc().clone().edit();
alice_doc3.visibility = Visibility::private([alice.signer.public_key().into()]);
let a3 = alice_identity
.update(
cob::Title::new("A3").unwrap(),
"",
&alice_doc3.verified().unwrap(),
)
.unwrap();
bob.repo.fetch(alice);
bob_identity.reload().unwrap();
bob_identity.accept(&a3).unwrap();
alice.repo.fetch(bob);
alice_identity.reload().unwrap();
assert_eq!(alice_identity.revision(&a3).unwrap().state, State::Accepted);
alice_identity.redact(a3).unwrap();
assert_eq!(alice_identity.revision(&a3).unwrap().state, State::Accepted);
let mut alice_doc4 = alice_identity.doc().clone().edit();
alice_doc4.visibility = Visibility::private([]);
let a4 = alice_identity
.update(
cob::Title::new("A4").unwrap(),
"",
&alice_doc4.verified().unwrap(),
)
.unwrap();
bob.repo.fetch(alice);
bob_identity.reload().unwrap();
bob_identity.reject(a4).unwrap();
alice.repo.fetch(bob);
alice_identity.reload().unwrap();
assert_eq!(
alice_identity.revision(&a4).unwrap().state,
State::Rejected(RejectedBy::Vote)
);
// a4 (Propose "A4") 1/2 (Rejected by Bob) -> Redact attempt ignored
// |
// a3 (Propose "A3") 2/2 (Accepted by Alice, Bob) -> Redact attempt ignored
// | \
// | a2 (Propose "A2") 1/2 (Redacted by Alice concurrently with Bob's Accept)
// | /
// a1 (Add Bob) 2/2 (Accepted by Alice, Bob)
// |
// a0
alice_identity.redact(a4).unwrap();
assert_eq!(
alice_identity.revision(&a4).unwrap().state,
State::Rejected(RejectedBy::Vote)
);
}
#[test]
fn test_valid_identity() {
let tempdir = tempfile::tempdir().unwrap();