mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle: sign blob hash instead of content 

The signatures for Radicle identities were using the documents
content.

It is standard to use the hash of the content instead, since signing
and verification is faster on a smaller set of data.

Use the resulting Git blob's object id, i.e. `git hash-object`, as the
signing and verifying payload.

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
This commit is contained in:
Fintan Halpenny 2023-02-10 15:33:24 +00:00 committed by Alexis Sellier
parent 99c1e2ac52
commit 540c56cac6
No known key found for this signature in database
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
radicle/src/identity/doc.rs
View File

@ -208,8 +208,8 @@ impl Doc<Verified> {
}
pub fn sign<G: crypto::Signer>(&self, signer: &G) -> Result<(git::Oid, Signature), DocError> {
let (oid, bytes) = self.encode()?;
let sig = signer.sign(&bytes);
let (oid, _) = self.encode()?;
let sig = signer.sign(oid.as_bytes());
Ok((oid, sig))
}
@ -224,7 +224,7 @@ impl Doc<Verified> {
let sigs = trailers::parse_signatures(msg)?;
for (pk, sig) in &sigs {
if let Err(err) = pk.verify(blob.content(), sig) {
if let Err(err) = pk.verify(blob.id().as_bytes(), sig) {
return Err(DocError::Signature(*pk, err));
}
}

2
radicle/src/storage/git.rs
View File

@ -245,7 +245,7 @@ impl Repository {
let oid = Doc::init(
doc.as_slice(),
remote,
&[(signer.public_key(), signer.sign(&doc))],
&[(signer.public_key(), signer.sign(doc_oid.as_bytes()))],
repo.raw(),
)?;