mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

node: Fix flaky limitter test 

Ensures the addresses are different.
This commit is contained in:
cloudhead 2023-08-09 17:07:21 +02:00
parent 8060181b9f
commit 593f576ab4
No known key found for this signature in database
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
radicle-node/src/service/limitter.rs
View File

@ -99,9 +99,6 @@ impl TokenBucket {
#[cfg(test)] #[cfg(test)]
#[allow(clippy::bool_assert_comparison, clippy::redundant_clone)] #[allow(clippy::bool_assert_comparison, clippy::redundant_clone)]
mod test { mod test {
use radicle::node::Address;
use radicle::test::arbitrary::gen;
use super::*; use super::*;
impl AsTokens for (usize, f64) { impl AsTokens for (usize, f64) {
@ -118,7 +115,7 @@ mod test {
fn test_limitter_refill() { fn test_limitter_refill() {
let mut r = RateLimiter::default(); let mut r = RateLimiter::default();
let t = (3, 0.2); // Three tokens burst. One token every 5 seconds. let t = (3, 0.2); // Three tokens burst. One token every 5 seconds.
let a: HostName = gen::<Address>(1).into(); let a = HostName::Dns(String::from("seed.radicle.xyz"));
assert_eq!(r.limit(a.clone(), &t, LocalTime::from_secs(0)), false); // Burst capacity assert_eq!(r.limit(a.clone(), &t, LocalTime::from_secs(0)), false); // Burst capacity
assert_eq!(r.limit(a.clone(), &t, LocalTime::from_secs(1)), false); // Burst capacity assert_eq!(r.limit(a.clone(), &t, LocalTime::from_secs(1)), false); // Burst capacity
@ -147,8 +144,8 @@ mod test {
fn test_limitter_multi() { fn test_limitter_multi() {
let t = (1, 1.0); // One token per second. One token burst. let t = (1, 1.0); // One token per second. One token burst.
let mut r = RateLimiter::default(); let mut r = RateLimiter::default();
let addr1: HostName = gen::<Address>(1).into(); let addr1 = HostName::Dns(String::from("seed.radicle.xyz"));
let addr2: HostName = gen::<Address>(1).into(); let addr2 = HostName::Dns(String::from("seed.radicle.net"));
assert_eq!(r.limit(addr1.clone(), &t, LocalTime::from_secs(0)), false); assert_eq!(r.limit(addr1.clone(), &t, LocalTime::from_secs(0)), false);
assert_eq!(r.limit(addr1.clone(), &t, LocalTime::from_secs(0)), true); assert_eq!(r.limit(addr1.clone(), &t, LocalTime::from_secs(0)), true);
@ -165,8 +162,8 @@ mod test {
let t1 = (1, 1.0); // One token per second. One token burst. let t1 = (1, 1.0); // One token per second. One token burst.
let t2 = (2, 2.0); // Two tokens per second. Two token burst. let t2 = (2, 2.0); // Two tokens per second. Two token burst.
let mut r = RateLimiter::default(); let mut r = RateLimiter::default();
let addr1: HostName = gen::<Address>(1).into(); let addr1 = HostName::Dns(String::from("seed.radicle.xyz"));
let addr2: HostName = gen::<Address>(1).into(); let addr2 = HostName::Dns(String::from("seed.radicle.net"));
assert_eq!(r.limit(addr1.clone(), &t1, LocalTime::from_secs(0)), false); assert_eq!(r.limit(addr1.clone(), &t1, LocalTime::from_secs(0)), false);
assert_eq!(r.limit(addr1.clone(), &t1, LocalTime::from_secs(0)), true); assert_eq!(r.limit(addr1.clone(), &t1, LocalTime::from_secs(0)), true);