From 6d698bb79414f1bfbeacda9c6ee352a2aae1f6ce Mon Sep 17 00:00:00 2001
From: Lorenz Leutgeb <lorenz.leutgeb@radicle.xyz>
Date: Sun, 28 Sep 2025 19:02:48 +0200
Subject: [PATCH] cli/block: Use clap

---
 crates/radicle-cli/src/commands/block.rs      | 86 ++-----------------
 crates/radicle-cli/src/commands/block/args.rs | 79 +++++++++++++++++
 crates/radicle-cli/src/commands/help.rs       |  5 +-
 crates/radicle-cli/src/main.rs                |  5 +-
 4 files changed, 94 insertions(+), 81 deletions(-)
 create mode 100644 crates/radicle-cli/src/commands/block/args.rs

diff --git a/crates/radicle-cli/src/commands/block.rs b/crates/radicle-cli/src/commands/block.rs
index a39f571c..c90e77a8 100644
--- a/crates/radicle-cli/src/commands/block.rs
+++ b/crates/radicle-cli/src/commands/block.rs
@@ -1,96 +1,24 @@
-use std::ffi::OsString;
+mod args;
 
 use radicle::node::policy::Policy;
-use radicle::prelude::{NodeId, RepoId};
 
 use crate::terminal as term;
-use crate::terminal::args;
-use crate::terminal::args::{Args, Error, Help};
 
-pub const HELP: Help = Help {
-    name: "block",
-    description: "Block repositories or nodes from being seeded or followed",
-    version: env!("RADICLE_VERSION"),
-    usage: r#"
-Usage
+use args::Target;
 
-    rad block <rid> [<option>...]
-    rad block <nid> [<option>...]
+pub use args::Args;
+pub(crate) use args::ABOUT;
 
-    Blocks a repository from being seeded or a node from being followed.
-
-Options
-
-    --help          Print help
-"#,
-};
-
-enum Target {
-    Node(NodeId),
-    Repo(RepoId),
-}
-
-impl std::fmt::Display for Target {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        match self {
-            Self::Node(nid) => nid.fmt(f),
-            Self::Repo(rid) => rid.fmt(f),
-        }
-    }
-}
-
-pub struct Options {
-    target: Target,
-}
-
-impl Args for Options {
-    fn from_args(args: Vec<OsString>) -> anyhow::Result<(Self, Vec<OsString>)> {
-        use lexopt::prelude::*;
-
-        let mut parser = lexopt::Parser::from_args(args);
-        let mut target = None;
-
-        while let Some(arg) = parser.next()? {
-            match arg {
-                Long("help") | Short('h') => {
-                    return Err(Error::Help.into());
-                }
-                Value(val) if target.is_none() => {
-                    if let Ok(rid) = args::rid(&val) {
-                        target = Some(Target::Repo(rid));
-                    } else if let Ok(nid) = args::nid(&val) {
-                        target = Some(Target::Node(nid));
-                    } else {
-                        anyhow::bail!(
-                            "invalid repository or node specified, see `rad block --help`"
-                        )
-                    }
-                }
-                _ => anyhow::bail!(arg.unexpected()),
-            }
-        }
-
-        Ok((
-            Options {
-                target: target.ok_or(anyhow::anyhow!(
-                    "a repository or node to block must be specified, see `rad block --help`"
-                ))?,
-            },
-            vec![],
-        ))
-    }
-}
-
-pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
+pub fn run(args: Args, ctx: impl term::Context) -> anyhow::Result<()> {
     let profile = ctx.profile()?;
     let mut policies = profile.policies_mut()?;
 
-    let updated = match options.target {
+    let updated = match args.target {
         Target::Node(nid) => policies.set_follow_policy(&nid, Policy::Block)?,
         Target::Repo(rid) => policies.set_seed_policy(&rid, Policy::Block)?,
     };
     if updated {
-        term::success!("Policy for {} set to 'block'", options.target);
+        term::success!("Policy for {} set to 'block'", args.target);
     }
     Ok(())
 }
diff --git a/crates/radicle-cli/src/commands/block/args.rs b/crates/radicle-cli/src/commands/block/args.rs
new file mode 100644
index 00000000..9174f573
--- /dev/null
+++ b/crates/radicle-cli/src/commands/block/args.rs
@@ -0,0 +1,79 @@
+use clap::Parser;
+use thiserror::Error;
+
+use radicle::prelude::{NodeId, RepoId};
+
+pub(crate) const ABOUT: &str = "Block repositories or nodes from being seeded or followed";
+
+#[derive(Clone, Debug)]
+pub(super) enum Target {
+    Node(NodeId),
+    Repo(RepoId),
+}
+
+#[derive(Debug, Error)]
+#[error("invalid repository or node specified (RID parsing failed with: '{repo}', NID parsing failed with: '{node}'))")]
+pub(super) struct ParseTargetError {
+    repo: radicle::identity::IdError,
+    node: radicle::crypto::PublicKeyError,
+}
+
+impl std::str::FromStr for Target {
+    type Err = ParseTargetError;
+
+    fn from_str(val: &str) -> Result<Self, Self::Err> {
+        val.parse::<RepoId>().map(Target::Repo).or_else(|repo| {
+            val.parse::<NodeId>()
+                .map(Target::Node)
+                .map_err(|node| ParseTargetError { repo, node })
+        })
+    }
+}
+
+impl std::fmt::Display for Target {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            Self::Node(nid) => nid.fmt(f),
+            Self::Repo(rid) => rid.fmt(f),
+        }
+    }
+}
+
+#[derive(Parser, Debug)]
+#[command(about = ABOUT, disable_version_flag = true)]
+pub struct Args {
+    /// A Repository ID or Node ID to block from seeding or following (respectively)
+    ///
+    /// Example values:
+    /// - z6MkiswaKJ85vafhffCGBu2gdBsYoDAyHVBWRxL3j297fwS9 (Node ID)
+    /// - rad:z3Tr6bC7ctEg2EHmLvknUr29mEDLH (Repository ID)
+    #[arg(value_name = "RID|NID", verbatim_doc_comment)]
+    pub(super) target: Target,
+}
+
+#[cfg(test)]
+mod test {
+    use clap::error::ErrorKind;
+    use clap::Parser;
+
+    use super::Args;
+
+    #[test]
+    fn should_parse_nid() {
+        let args =
+            Args::try_parse_from(["block", "z6MkiswaKJ85vafhffCGBu2gdBsYoDAyHVBWRxL3j297fwS9"]);
+        assert!(args.is_ok())
+    }
+
+    #[test]
+    fn should_parse_rid() {
+        let args = Args::try_parse_from(["block", "rad:z3Tr6bC7ctEg2EHmLvknUr29mEDLH"]);
+        assert!(args.is_ok())
+    }
+
+    #[test]
+    fn should_not_parse() {
+        let err = Args::try_parse_from(["block", "bee"]).unwrap_err();
+        assert_eq!(err.kind(), ErrorKind::ValueValidation);
+    }
+}
diff --git a/crates/radicle-cli/src/commands/help.rs b/crates/radicle-cli/src/commands/help.rs
index 459df8fa..116f2be4 100644
--- a/crates/radicle-cli/src/commands/help.rs
+++ b/crates/radicle-cli/src/commands/help.rs
@@ -38,7 +38,10 @@ impl CommandItem {
 
 const COMMANDS: &[CommandItem] = &[
     CommandItem::Lexopt(crate::commands::auth::HELP),
-    CommandItem::Lexopt(crate::commands::block::HELP),
+    CommandItem::Clap {
+        name: "block",
+        about: crate::commands::block::ABOUT,
+    },
     CommandItem::Lexopt(crate::commands::checkout::HELP),
     CommandItem::Lexopt(crate::commands::clone::HELP),
     CommandItem::Lexopt(crate::commands::config::HELP),
diff --git a/crates/radicle-cli/src/main.rs b/crates/radicle-cli/src/main.rs
index 20ce37f6..b443b574 100644
--- a/crates/radicle-cli/src/main.rs
+++ b/crates/radicle-cli/src/main.rs
@@ -45,6 +45,7 @@ struct CliArgs {
 
 #[derive(Subcommand, Debug)]
 enum Commands {
+    Block(block::Args),
     Clean(clean::Args),
     Issue(issue::Args),
     Path(path::Args),
@@ -178,7 +179,9 @@ pub(crate) fn run_other(exe: &str, args: &[OsString]) -> Result<(), Option<anyho
             term::run_command_args::<auth::Options, _>(auth::HELP, auth::run, args.to_vec());
         }
         "block" => {
-            term::run_command_args::<block::Options, _>(block::HELP, block::run, args.to_vec());
+            if let Some(Commands::Block(args)) = CliArgs::parse().command {
+                term::run_command_fn(block::run, args);
+            }
         }
         "checkout" => {
             term::run_command_args::<checkout::Options, _>(