From 7b00bf2e3ac5e83eab262182bf51a5ede656145c Mon Sep 17 00:00:00 2001 From: Lorenz Leutgeb Date: Wed, 17 Sep 2025 08:56:58 +0200 Subject: [PATCH] cli/patch/review: Obsoletion Warning As discussed in: --- CHANGELOG.md | 3 +++ crates/radicle-cli/src/commands/patch/review.rs | 2 ++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 887c92cf..4d566711 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - The option `rad self --nid` was deprecated in favor of `rad status --only nid` - `rad diff` was deprecated in favor of using `git diff` +- `rad patch review --patch` and `rad patch review --delete` are made obsolete. + This functionality never worked as intended, and may be removed before the + next major release. ## New Features diff --git a/crates/radicle-cli/src/commands/patch/review.rs b/crates/radicle-cli/src/commands/patch/review.rs index ac4c7623..fe4e28eb 100644 --- a/crates/radicle-cli/src/commands/patch/review.rs +++ b/crates/radicle-cli/src/commands/patch/review.rs @@ -83,6 +83,7 @@ pub fn run( unified, hunk, } if by_hunk => { + crate::warning::obsolete("rad patch review --patch"); let mut opts = git::raw::DiffOptions::new(); opts.patience(true) .minimal(true) @@ -124,6 +125,7 @@ pub fn run( } } Operation::Delete => { + crate::warning::obsolete("rad patch review --delete"); let name = git::refs::storage::draft::review(profile.id(), &patch_id); match repository.backend.find_reference(&name) {