radicle: add remove to WriteStorage

Add the ability to remove a repository, given its RID.

This is useful in the case of attempting to clone a repository, and if
that process fails -- for example, if the repository is private --
then it's necessary to clean up the initially created repository.

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett

radicle/src/storage.rs

@@ -342,6 +342,8 @@ pub trait WriteStorage: ReadStorage {
     fn repository_mut(&self, rid: Id) -> Result<Self::RepositoryMut, Error>;
     /// Create a read-write repository.
     fn create(&self, rid: Id) -> Result<Self::RepositoryMut, Error>;
+    /// Delete a repository.
+    fn remove(&self, rid: Id) -> Result<(), Error>;
 }
 
 /// Allows read-only access to a repository.
@@ -575,6 +577,10 @@ where
     fn create(&self, rid: Id) -> Result<Self::RepositoryMut, Error> {
         self.deref().create(rid)
     }
+
+    fn remove(&self, rid: Id) -> Result<(), Error> {
+        self.deref().remove(rid)
+    }
 }
 
 #[cfg(test)]

radicle/src/storage/git.rs

@@ -127,6 +127,10 @@ impl WriteStorage for Storage {
     fn create(&self, rid: Id) -> Result<Self::RepositoryMut, Error> {
         Repository::create(paths::repository(self, &rid), rid)
     }
+
+    fn remove(&self, rid: Id) -> Result<(), Error> {
+        self.repository(rid)?.remove()
+    }
 }
 
 impl Storage {
@@ -299,6 +303,15 @@ impl Repository {
         Ok(Self { id, backend })
     }
 
+    /// Remove an existing repository
+    pub fn remove(&self) -> Result<(), Error> {
+        let path = self.backend.path();
+        if path.exists() {
+            fs::remove_dir_all(path)?;
+        }
+        Ok(())
+    }
+
     /// Create the repository's identity branch.
     pub fn init<G: Signer, S: WriteStorage>(
         doc: &Doc<Verified>,

radicle/src/test/storage.rs

@@ -99,6 +99,10 @@ impl WriteStorage for MockStorage {
     fn create(&self, _rid: Id) -> Result<Self::RepositoryMut, Error> {
         todo!()
     }
+
+    fn remove(&self, _rid: Id) -> Result<(), Error> {
+        todo!()
+    }
 }
 
 #[derive(Clone, Debug)]