mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Protect ourselves against naked refs 

Signed-off-by: Alexis Sellier <alexis@radicle.xyz>
This commit is contained in:
Alexis Sellier 2022-10-20 12:59:55 +02:00
parent 1906124497
commit 8b834a7b6e
No known key found for this signature in database
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
radicle/src/storage/git.rs
View File

@ -604,13 +604,15 @@ impl WriteRepository for Repository {
callbacks.update_tips(|name, old, new| {
if let Ok(name) = git::RefString::try_from(name) {
updates.push(RefUpdate::from(name, old, new));
} else {
log::warn!("Invalid ref `{}` detected; aborting fetch", name);
return false;
if name.to_namespaced().is_some() {
updates.push(RefUpdate::from(name, old, new));
// Returning `true` ensures the process is not aborted.
return true;
}
}
// Returning `true` ensures the process is not aborted.
true
log::warn!("Invalid ref `{}` detected; aborting fetch", name);
false
});
{
@ -813,6 +815,15 @@ mod tests {
assert_eq!(alice_oid.target(), bob_oid.target());
}
// Canonical HEAD is set correctly.
let alice_repo = alice.repository(proj).unwrap();
let bob_repo = bob.repository(proj).unwrap();
assert_eq!(
bob_repo.backend.head().unwrap().target().unwrap(),
alice_repo.backend.head().unwrap().target().unwrap()
);
}
#[test]