diff --git a/.rustfmt.toml b/.rustfmt.toml index 3a26366d..f216078d 100644 --- a/.rustfmt.toml +++ b/.rustfmt.toml @@ -1 +1 @@ -edition = "2021" +edition = "2024" diff --git a/crates/radicle-cli/src/commands/auth.rs b/crates/radicle-cli/src/commands/auth.rs index 100b9a96..ccb95374 100644 --- a/crates/radicle-cli/src/commands/auth.rs +++ b/crates/radicle-cli/src/commands/auth.rs @@ -3,13 +3,13 @@ mod args; use std::str::FromStr; -use anyhow::{anyhow, Context}; +use anyhow::{Context, anyhow}; use radicle::crypto::ssh; use radicle::crypto::ssh::Passphrase; use radicle::node::Alias; use radicle::profile::env; -use radicle::{profile, Profile}; +use radicle::{Profile, profile}; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/block/args.rs b/crates/radicle-cli/src/commands/block/args.rs index f75cdcd3..cbba7e59 100644 --- a/crates/radicle-cli/src/commands/block/args.rs +++ b/crates/radicle-cli/src/commands/block/args.rs @@ -16,8 +16,8 @@ pub struct Args { #[cfg(test)] mod test { - use clap::error::ErrorKind; use clap::Parser; + use clap::error::ErrorKind; use super::Args; diff --git a/crates/radicle-cli/src/commands/checkout.rs b/crates/radicle-cli/src/commands/checkout.rs index 9cc7a4dd..a4b185ac 100644 --- a/crates/radicle-cli/src/commands/checkout.rs +++ b/crates/radicle-cli/src/commands/checkout.rs @@ -3,8 +3,8 @@ mod args; use std::path::PathBuf; -use anyhow::anyhow; use anyhow::Context as _; +use anyhow::anyhow; use radicle::git; use radicle::node::AliasStore; diff --git a/crates/radicle-cli/src/commands/clone/args.rs b/crates/radicle-cli/src/commands/clone/args.rs index cabaf192..2a8ddf46 100644 --- a/crates/radicle-cli/src/commands/clone/args.rs +++ b/crates/radicle-cli/src/commands/clone/args.rs @@ -2,15 +2,15 @@ use std::path::PathBuf; use clap::Parser; -use radicle::identity::doc::RepoId; use radicle::identity::IdError; +use radicle::identity::doc::RepoId; use radicle::node::policy::Scope; use radicle::prelude::*; use radicle::storage::refs; use crate::common_args::{ - SignedReferencesFeatureLevel, SignedReferencesFeatureLevelParser, - ABOUT_FETCH_SIGNED_REFERENCES_FEATURE_LEVEL_MINIMUM, + ABOUT_FETCH_SIGNED_REFERENCES_FEATURE_LEVEL_MINIMUM, SignedReferencesFeatureLevel, + SignedReferencesFeatureLevelParser, }; use crate::node::SyncSettings; use crate::terminal; diff --git a/crates/radicle-cli/src/commands/cob.rs b/crates/radicle-cli/src/commands/cob.rs index 940414c5..12b92364 100644 --- a/crates/radicle-cli/src/commands/cob.rs +++ b/crates/radicle-cli/src/commands/cob.rs @@ -21,7 +21,7 @@ use crate::terminal as term; pub use args::Args; -use args::{parse_many_embeds, FilteredTypeName, Format}; +use args::{FilteredTypeName, Format, parse_many_embeds}; fn embeds( repo: &storage::git::Repository, diff --git a/crates/radicle-cli/src/commands/cob/args.rs b/crates/radicle-cli/src/commands/cob/args.rs index bd5f388b..fcada46a 100644 --- a/crates/radicle-cli/src/commands/cob/args.rs +++ b/crates/radicle-cli/src/commands/cob/args.rs @@ -339,8 +339,8 @@ impl std::str::FromStr for FilteredTypeName { #[cfg(test)] mod test { use super::Args; - use clap::error::ErrorKind; use clap::Parser; + use clap::error::ErrorKind; const ARGS: &[&str] = &[ "--repo", diff --git a/crates/radicle-cli/src/commands/config.rs b/crates/radicle-cli/src/commands/config.rs index a74c8409..ae67a407 100644 --- a/crates/radicle-cli/src/commands/config.rs +++ b/crates/radicle-cli/src/commands/config.rs @@ -5,7 +5,7 @@ use args::Command; use std::path::Path; -use radicle::profile::{config, Config, ConfigPath, RawConfig}; +use radicle::profile::{Config, ConfigPath, RawConfig, config}; use crate::terminal as term; use crate::terminal::Element as _; diff --git a/crates/radicle-cli/src/commands/follow.rs b/crates/radicle-cli/src/commands/follow.rs index aa214cd2..27dff43b 100644 --- a/crates/radicle-cli/src/commands/follow.rs +++ b/crates/radicle-cli/src/commands/follow.rs @@ -1,7 +1,7 @@ mod args; -use radicle::node::{policy, Alias, AliasStore, Handle, NodeId}; -use radicle::{prelude::*, Node}; +use radicle::node::{Alias, AliasStore, Handle, NodeId, policy}; +use radicle::{Node, prelude::*}; use radicle_term::{Element as _, Paint, Table}; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/fork/args.rs b/crates/radicle-cli/src/commands/fork/args.rs index a2374b3d..850a0b15 100644 --- a/crates/radicle-cli/src/commands/fork/args.rs +++ b/crates/radicle-cli/src/commands/fork/args.rs @@ -25,8 +25,8 @@ pub struct Args { #[cfg(test)] mod test { use super::Args; - use clap::error::ErrorKind; use clap::Parser; + use clap::error::ErrorKind; #[test] fn should_parse_rid_non_urn() { diff --git a/crates/radicle-cli/src/commands/id.rs b/crates/radicle-cli/src/commands/id.rs index 2194fb2c..f4018f53 100644 --- a/crates/radicle-cli/src/commands/id.rs +++ b/crates/radicle-cli/src/commands/id.rs @@ -2,21 +2,21 @@ mod args; use std::collections::BTreeSet; -use anyhow::{anyhow, Context}; +use anyhow::{Context, anyhow}; -use radicle::cob::identity::{self, IdentityMut, Revision, RevisionId}; use radicle::cob::Title; +use radicle::cob::identity::{self, IdentityMut, Revision, RevisionId}; use radicle::identity::doc::update; -use radicle::identity::{doc, Doc, Identity, RawDoc}; -use radicle::node::device::Device; +use radicle::identity::{Doc, Identity, RawDoc, doc}; use radicle::node::NodeId; +use radicle::node::device::Device; use radicle::storage::{ReadStorage as _, WriteRepository}; -use radicle::{cob, crypto, Profile}; +use radicle::{Profile, cob, crypto}; use radicle_surf::diff::Diff; use radicle_term::Element; -use crate::git::unified_diff::Encode as _; use crate::git::Rev; +use crate::git::unified_diff::Encode as _; use crate::terminal as term; use crate::terminal::args::Error; use crate::terminal::format::Author; diff --git a/crates/radicle-cli/src/commands/id/args.rs b/crates/radicle-cli/src/commands/id/args.rs index c123b0ef..d83e6029 100644 --- a/crates/radicle-cli/src/commands/id/args.rs +++ b/crates/radicle-cli/src/commands/id/args.rs @@ -8,9 +8,9 @@ use serde_json as json; use thiserror::Error; use radicle::cob::{Title, TypeNameParse}; +use radicle::identity::doc::PayloadId; use radicle::identity::doc::update::EditVisibility; use radicle::identity::doc::update::PayloadUpsert; -use radicle::identity::doc::PayloadId; use radicle::prelude::{Did, RepoId}; use crate::git::Rev; @@ -240,9 +240,9 @@ pub(super) enum Command { #[cfg(test)] mod test { - use super::{parse_many_upserts, Args}; - use clap::error::ErrorKind; + use super::{Args, parse_many_upserts}; use clap::Parser; + use clap::error::ErrorKind; #[test] fn should_parse_single_payload() { diff --git a/crates/radicle-cli/src/commands/inbox.rs b/crates/radicle-cli/src/commands/inbox.rs index 616e3382..91f7ec04 100644 --- a/crates/radicle-cli/src/commands/inbox.rs +++ b/crates/radicle-cli/src/commands/inbox.rs @@ -9,8 +9,8 @@ use anyhow::anyhow; use localtime::LocalTime; use radicle::cob::TypedId; -use radicle::git::fmt::Qualified; use radicle::git::BranchName; +use radicle::git::fmt::Qualified; use radicle::identity::Identity; use radicle::issue::cache::Issues as _; use radicle::node::notifications; @@ -18,7 +18,7 @@ use radicle::node::notifications::*; use radicle::patch::cache::Patches as _; use radicle::prelude::{NodeId, Profile, RepoId}; use radicle::storage::{ReadRepository, ReadStorage}; -use radicle::{cob, git, Storage}; +use radicle::{Storage, cob, git}; use term::Element as _; diff --git a/crates/radicle-cli/src/commands/init.rs b/crates/radicle-cli/src/commands/init.rs index 217a13a7..997bcf65 100644 --- a/crates/radicle-cli/src/commands/init.rs +++ b/crates/radicle-cli/src/commands/init.rs @@ -10,7 +10,7 @@ use std::convert::TryFrom; use std::env; use std::str::FromStr; -use anyhow::{anyhow, bail, Context as _}; +use anyhow::{Context as _, anyhow, bail}; use serde_json as json; use radicle::crypto::ssh; @@ -21,9 +21,9 @@ use radicle::git::raw::ErrorExt as _; use radicle::identity::project::ProjectName; use radicle::identity::{Doc, RepoId, Visibility}; use radicle::node::events::UploadPack; -use radicle::node::{Event, Handle, NodeId, DEFAULT_SUBSCRIBE_TIMEOUT}; +use radicle::node::{DEFAULT_SUBSCRIBE_TIMEOUT, Event, Handle, NodeId}; use radicle::storage::ReadStorage as _; -use radicle::{profile, Node}; +use radicle::{Node, profile}; use crate::commands; use crate::git; @@ -63,7 +63,9 @@ pub fn init(repo: git::Repository, args: Args, profile: &profile::Profile) -> an let default_branch = match find_default_branch(&repo) { Err(err @ DefaultBranchError::Head) => { term::error(err); - term::hint("try `git checkout ` or set `git config set --local init.defaultBranch `"); + term::hint( + "try `git checkout ` or set `git config set --local init.defaultBranch `", + ); anyhow::bail!("aborting `rad init`") } Err(err @ DefaultBranchError::NoHead) => { @@ -209,7 +211,9 @@ pub fn init(repo: git::Repository, args: Args, profile: &profile::Profile) -> an term::warning(format!( "There was an error announcing your repository to the network: {e}" )); - term::warning("Try again with `rad sync --announce`, or check your logs with `rad node logs`."); + term::warning( + "Try again with `rad sync --announce`, or check your logs with `rad node logs`.", + ); term::blank(); } term::info!("To push changes, run {}.", term::format::command(push_cmd)); @@ -445,7 +449,8 @@ pub fn announce( term::blank(); term::info!( "You are not connected to any peers. Your repository will be announced as soon as \ - your node establishes a connection with the network."); + your node establishes a connection with the network." + ); term::info!("Check for peer connections with `rad node status`."); term::blank(); } diff --git a/crates/radicle-cli/src/commands/init/args.rs b/crates/radicle-cli/src/commands/init/args.rs index d45e3268..f10fc434 100644 --- a/crates/radicle-cli/src/commands/init/args.rs +++ b/crates/radicle-cli/src/commands/init/args.rs @@ -2,7 +2,7 @@ use std::path::PathBuf; use clap::Parser; use radicle::{ - identity::{project::ProjectName, Visibility}, + identity::{Visibility, project::ProjectName}, node::policy::Scope, prelude::RepoId, }; @@ -115,8 +115,8 @@ impl clap::builder::TypedValueParser for ScopeParser { #[cfg(test)] mod test { use super::Args; - use clap::error::ErrorKind; use clap::Parser; + use clap::error::ErrorKind; #[test] fn should_parse_rid_non_urn() { diff --git a/crates/radicle-cli/src/commands/inspect.rs b/crates/radicle-cli/src/commands/inspect.rs index 70194dc4..9b473c6e 100644 --- a/crates/radicle-cli/src/commands/inspect.rs +++ b/crates/radicle-cli/src/commands/inspect.rs @@ -11,15 +11,15 @@ use chrono::prelude::*; use radicle::identity::RepoId; use radicle::identity::{DocAt, Identity}; -use radicle::node::policy::SeedingPolicy; use radicle::node::AliasStore as _; +use radicle::node::policy::SeedingPolicy; use radicle::storage::git::{Repository, Storage}; use radicle::storage::refs::{FeatureLevel, RefsAt, SignedRefs}; use radicle::storage::{ReadRepository, ReadStorage}; use crate::terminal as term; -use crate::terminal::json; use crate::terminal::Element; +use crate::terminal::json; pub use args::Args; use args::Target; diff --git a/crates/radicle-cli/src/commands/issue.rs b/crates/radicle-cli/src/commands/issue.rs index 79f1cedb..2efc4d21 100644 --- a/crates/radicle-cli/src/commands/issue.rs +++ b/crates/radicle-cli/src/commands/issue.rs @@ -6,18 +6,18 @@ use anyhow::Context as _; use radicle::cob::common::Label; use radicle::cob::issue::{CloseReason, State}; -use radicle::cob::{issue, Title}; +use radicle::cob::{Title, issue}; +use radicle::Profile; use radicle::crypto; use radicle::issue::cache::Issues as _; -use radicle::node::device::Device; use radicle::node::NodeId; +use radicle::node::device::Device; use radicle::prelude::Did; use radicle::profile; use radicle::storage; use radicle::storage::{WriteRepository, WriteStorage}; -use radicle::Profile; -use radicle::{cob, Node}; +use radicle::{Node, cob}; pub use args::Args; use args::{Assigned, Command, CommentAction, StateArg}; @@ -25,10 +25,10 @@ use args::{Assigned, Command, CommentAction, StateArg}; use crate::git::Rev; use crate::node; use crate::terminal as term; +use crate::terminal::Element; use crate::terminal::args::Error; use crate::terminal::format::Author; use crate::terminal::issue::Format; -use crate::terminal::Element; const ABOUT: &str = "Manage issues"; diff --git a/crates/radicle-cli/src/commands/issue/args.rs b/crates/radicle-cli/src/commands/issue/args.rs index b49e56a8..e48a974f 100644 --- a/crates/radicle-cli/src/commands/issue/args.rs +++ b/crates/radicle-cli/src/commands/issue/args.rs @@ -4,7 +4,7 @@ use clap::{Parser, Subcommand}; use radicle::{ cob::{Label, Reaction, Title}, - identity::{did::DidError, Did, RepoId}, + identity::{Did, RepoId, did::DidError}, issue::{CloseReason, State}, }; diff --git a/crates/radicle-cli/src/commands/issue/cache.rs b/crates/radicle-cli/src/commands/issue/cache.rs index 8993dc2e..e2fb606c 100644 --- a/crates/radicle-cli/src/commands/issue/cache.rs +++ b/crates/radicle-cli/src/commands/issue/cache.rs @@ -1,9 +1,9 @@ use std::ops::ControlFlow; -use radicle::issue::IssueId; -use radicle::storage::git::Repository; -use radicle::storage::ReadStorage as _; use radicle::Profile; +use radicle::issue::IssueId; +use radicle::storage::ReadStorage as _; +use radicle::storage::git::Repository; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/issue/comment.rs b/crates/radicle-cli/src/commands/issue/comment.rs index 665f0462..d072716f 100644 --- a/crates/radicle-cli/src/commands/issue/comment.rs +++ b/crates/radicle-cli/src/commands/issue/comment.rs @@ -1,12 +1,12 @@ +use radicle::Profile; use radicle::cob::thread; use radicle::storage::WriteRepository; -use radicle::Profile; use radicle::{cob, git, issue, storage}; use crate::git::Rev; use crate::terminal as term; -use crate::terminal::patch::Message; use crate::terminal::Element as _; +use crate::terminal::patch::Message; pub(super) fn comment( profile: &Profile, diff --git a/crates/radicle-cli/src/commands/node.rs b/crates/radicle-cli/src/commands/node.rs index 4e227bf4..f7f2f722 100644 --- a/crates/radicle-cli/src/commands/node.rs +++ b/crates/radicle-cli/src/commands/node.rs @@ -7,11 +7,11 @@ pub mod routing; use std::{process, time}; +use radicle::node::Handle as _; +use radicle::node::Node; use radicle::node::address::Store as AddressStore; use radicle::node::config::ConnectAddress; use radicle::node::routing::Store; -use radicle::node::Handle as _; -use radicle::node::Node; use crate::commands::node::args::Only; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/node/control.rs b/crates/radicle-cli/src/commands/node/control.rs index cb1473e8..c2805293 100644 --- a/crates/radicle-cli/src/commands/node/control.rs +++ b/crates/radicle-cli/src/commands/node/control.rs @@ -4,14 +4,14 @@ use std::fs::File; use std::io::{BufRead, BufReader, Read, Seek, SeekFrom, Write}; use std::{path::Path, process, thread, time}; -use anyhow::{anyhow, Context}; +use anyhow::{Context, anyhow}; use localtime::LocalTime; +use radicle::Node; use radicle::node; use radicle::node::{Address, ConnectResult, Handle as _, NodeId}; use radicle::profile::env::RAD_PASSPHRASE; -use radicle::Node; -use radicle::{profile, Profile}; +use radicle::{Profile, profile}; use crate::commands::node::logs::{LogRotatorFileSystem, Rotated}; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch.rs b/crates/radicle-cli/src/commands/patch.rs index c7666712..c4a17907 100644 --- a/crates/radicle-cli/src/commands/patch.rs +++ b/crates/radicle-cli/src/commands/patch.rs @@ -22,10 +22,10 @@ use std::collections::BTreeSet; use anyhow::anyhow; use radicle::cob::patch::PatchId; -use radicle::cob::{patch, Label}; +use radicle::cob::{Label, patch}; use radicle::patch::cache::Patches as _; use radicle::storage::git::transport; -use radicle::{prelude::*, Node}; +use radicle::{Node, prelude::*}; use crate::git::Rev; use crate::node; diff --git a/crates/radicle-cli/src/commands/patch/cache.rs b/crates/radicle-cli/src/commands/patch/cache.rs index b04f5a00..f04e1c45 100644 --- a/crates/radicle-cli/src/commands/patch/cache.rs +++ b/crates/radicle-cli/src/commands/patch/cache.rs @@ -1,9 +1,9 @@ use std::ops::ControlFlow; -use radicle::patch::PatchId; -use radicle::storage::git::Repository; -use radicle::storage::ReadStorage as _; use radicle::Profile; +use radicle::patch::PatchId; +use radicle::storage::ReadStorage as _; +use radicle::storage::git::Repository; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/checkout.rs b/crates/radicle-cli/src/commands/patch/checkout.rs index ef1b400a..f49a4323 100644 --- a/crates/radicle-cli/src/commands/patch/checkout.rs +++ b/crates/radicle-cli/src/commands/patch/checkout.rs @@ -5,10 +5,10 @@ use radicle::cob::patch::RevisionId; use radicle::git::fmt::Qualified; use radicle::git::fmt::RefString; use radicle::git::raw::ErrorExt as _; -use radicle::patch::cache::Patches as _; use radicle::patch::PatchId; +use radicle::patch::cache::Patches as _; use radicle::storage::git::Repository; -use radicle::{git, rad, Profile}; +use radicle::{Profile, git, rad}; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/comment/edit.rs b/crates/radicle-cli/src/commands/patch/comment/edit.rs index eda591d0..b8d42846 100644 --- a/crates/radicle-cli/src/commands/patch/comment/edit.rs +++ b/crates/radicle-cli/src/commands/patch/comment/edit.rs @@ -1,12 +1,12 @@ use anyhow::anyhow; +use radicle::Profile; use radicle::cob; use radicle::cob::patch; use radicle::cob::thread; -use radicle::patch::cache::Patches as _; use radicle::patch::ByRevision; +use radicle::patch::cache::Patches as _; use radicle::storage::git::Repository; -use radicle::Profile; use crate::git; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/comment/react.rs b/crates/radicle-cli/src/commands/patch/comment/react.rs index 586fa49c..3f5f667b 100644 --- a/crates/radicle-cli/src/commands/patch/comment/react.rs +++ b/crates/radicle-cli/src/commands/patch/comment/react.rs @@ -1,13 +1,13 @@ use anyhow::anyhow; +use radicle::Profile; use radicle::cob; +use radicle::cob::Reaction; use radicle::cob::patch; use radicle::cob::thread; -use radicle::cob::Reaction; -use radicle::patch::cache::Patches as _; use radicle::patch::ByRevision; +use radicle::patch::cache::Patches as _; use radicle::storage::git::Repository; -use radicle::Profile; use crate::git; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/comment/redact.rs b/crates/radicle-cli/src/commands/patch/comment/redact.rs index b8ada9b4..d6de9c3c 100644 --- a/crates/radicle-cli/src/commands/patch/comment/redact.rs +++ b/crates/radicle-cli/src/commands/patch/comment/redact.rs @@ -1,12 +1,12 @@ use anyhow::anyhow; +use radicle::Profile; use radicle::cob; use radicle::cob::patch; use radicle::cob::thread; -use radicle::patch::cache::Patches as _; use radicle::patch::ByRevision; +use radicle::patch::cache::Patches as _; use radicle::storage::git::Repository; -use radicle::Profile; use crate::git; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/edit.rs b/crates/radicle-cli/src/commands/patch/edit.rs index d7e4ccff..4e0c7b58 100644 --- a/crates/radicle-cli/src/commands/patch/edit.rs +++ b/crates/radicle-cli/src/commands/patch/edit.rs @@ -1,8 +1,8 @@ use super::*; use radicle::cob; -use radicle::cob::patch; use radicle::cob::Title; +use radicle::cob::patch; use radicle::crypto; use radicle::node::device::Device; use radicle::prelude::*; diff --git a/crates/radicle-cli/src/commands/patch/list.rs b/crates/radicle-cli/src/commands/patch/list.rs index ff9f2d45..e3caca44 100644 --- a/crates/radicle-cli/src/commands/patch/list.rs +++ b/crates/radicle-cli/src/commands/patch/list.rs @@ -7,9 +7,9 @@ use radicle::prelude::*; use radicle::profile::Profile; use radicle::storage::git::Repository; +use term::Element as _; use term::format::Author; use term::table::{Table, TableOptions}; -use term::Element as _; use crate::terminal as term; use crate::terminal::patch as common; diff --git a/crates/radicle-cli/src/commands/patch/react.rs b/crates/radicle-cli/src/commands/patch/react.rs index 132659b5..400ea7bc 100644 --- a/crates/radicle-cli/src/commands/patch/react.rs +++ b/crates/radicle-cli/src/commands/patch/react.rs @@ -1,11 +1,11 @@ use anyhow::anyhow; -use radicle::cob; -use radicle::cob::{patch, Reaction}; -use radicle::patch::cache::Patches as _; -use radicle::patch::ByRevision; -use radicle::storage::git::Repository; use radicle::Profile; +use radicle::cob; +use radicle::cob::{Reaction, patch}; +use radicle::patch::ByRevision; +use radicle::patch::cache::Patches as _; +use radicle::storage::git::Repository; use crate::git; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/resolve.rs b/crates/radicle-cli/src/commands/patch/resolve.rs index e7b87f9a..08f34167 100644 --- a/crates/radicle-cli/src/commands/patch/resolve.rs +++ b/crates/radicle-cli/src/commands/patch/resolve.rs @@ -1,9 +1,9 @@ use anyhow::anyhow; +use radicle::Profile; use radicle::cob::thread::CommentId; use radicle::patch::{self, PatchId}; -use radicle::patch::{cache::Patches as _, ReviewId}; +use radicle::patch::{ReviewId, cache::Patches as _}; use radicle::storage::git::Repository; -use radicle::Profile; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/patch/review.rs b/crates/radicle-cli/src/commands/patch/review.rs index 5e3a398a..07e594bd 100644 --- a/crates/radicle-cli/src/commands/patch/review.rs +++ b/crates/radicle-cli/src/commands/patch/review.rs @@ -1,6 +1,6 @@ mod builder; -use anyhow::{anyhow, Context}; +use anyhow::{Context, anyhow}; use radicle::cob::patch::{PatchId, RevisionId, Verdict}; use radicle::git; diff --git a/crates/radicle-cli/src/commands/patch/review/builder.rs b/crates/radicle-cli/src/commands/patch/review/builder.rs index ba5c6b27..1962326c 100644 --- a/crates/radicle-cli/src/commands/patch/review/builder.rs +++ b/crates/radicle-cli/src/commands/patch/review/builder.rs @@ -26,7 +26,7 @@ use radicle::git; use radicle::git::Oid; use radicle::node::device::Device; use radicle::prelude::*; -use radicle::storage::git::{cob::DraftStore, Repository}; +use radicle::storage::git::{Repository, cob::DraftStore}; use radicle_surf::diff::*; use radicle_term::{Element, VStack}; diff --git a/crates/radicle-cli/src/commands/publish.rs b/crates/radicle-cli/src/commands/publish.rs index aca4b5d8..0cf3f3cf 100644 --- a/crates/radicle-cli/src/commands/publish.rs +++ b/crates/radicle-cli/src/commands/publish.rs @@ -1,6 +1,6 @@ mod args; -use anyhow::{anyhow, Context as _}; +use anyhow::{Context as _, anyhow}; use radicle::cob; use radicle::identity::{Identity, Visibility}; diff --git a/crates/radicle-cli/src/commands/publish/args.rs b/crates/radicle-cli/src/commands/publish/args.rs index ee0385af..bebdbc0e 100644 --- a/crates/radicle-cli/src/commands/publish/args.rs +++ b/crates/radicle-cli/src/commands/publish/args.rs @@ -27,8 +27,8 @@ pub struct Args { #[cfg(test)] mod test { use super::Args; - use clap::error::ErrorKind; use clap::Parser; + use clap::error::ErrorKind; #[test] fn should_parse_rid_non_urn() { diff --git a/crates/radicle-cli/src/commands/remote/add.rs b/crates/radicle-cli/src/commands/remote/add.rs index 7634eff3..f130e669 100644 --- a/crates/radicle-cli/src/commands/remote/add.rs +++ b/crates/radicle-cli/src/commands/remote/add.rs @@ -1,9 +1,9 @@ use std::str::FromStr; +use radicle::Profile; use radicle::git; use radicle::git::fmt::RefString; use radicle::prelude::*; -use radicle::Profile; use radicle_crypto::PublicKey; use crate::commands::checkout; diff --git a/crates/radicle-cli/src/commands/remote/list.rs b/crates/radicle-cli/src/commands/remote/list.rs index 7356cdd1..1a4e997f 100644 --- a/crates/radicle-cli/src/commands/remote/list.rs +++ b/crates/radicle-cli/src/commands/remote/list.rs @@ -1,10 +1,10 @@ use std::collections::HashSet; +use radicle::Profile; use radicle::git::Url; use radicle::identity::{Did, RepoId}; use radicle::node::{Alias, AliasStore as _, NodeId}; use radicle::storage::ReadStorage as _; -use radicle::Profile; use radicle_term::{Element, Table}; use crate::git; diff --git a/crates/radicle-cli/src/commands/seed.rs b/crates/radicle-cli/src/commands/seed.rs index 05294b13..fa2799fb 100644 --- a/crates/radicle-cli/src/commands/seed.rs +++ b/crates/radicle-cli/src/commands/seed.rs @@ -1,9 +1,9 @@ mod args; +use radicle::node::Handle; use radicle::node::policy; use radicle::node::policy::{Policy, Scope}; -use radicle::node::Handle; -use radicle::{prelude::*, Node}; +use radicle::{Node, prelude::*}; use radicle_term::Element as _; use crate::commands::sync; diff --git a/crates/radicle-cli/src/commands/sync.rs b/crates/radicle-cli/src/commands/sync.rs index 13661987..b0806fcd 100644 --- a/crates/radicle-cli/src/commands/sync.rs +++ b/crates/radicle-cli/src/commands/sync.rs @@ -5,13 +5,13 @@ use std::collections::BTreeMap; use std::collections::HashSet; use std::time; -use anyhow::{anyhow, Context as _}; +use anyhow::{Context as _, anyhow}; use radicle::node; +use radicle::node::SyncedAt; use radicle::node::address::Store; use radicle::node::sync; use radicle::node::sync::fetch::SuccessfulOutcome; -use radicle::node::SyncedAt; use radicle::node::{AliasStore, Handle as _, Node, Seed, SyncStatus}; use radicle::prelude::{NodeId, Profile, RepoId}; use radicle::storage::ReadRepository; diff --git a/crates/radicle-cli/src/commands/sync/args.rs b/crates/radicle-cli/src/commands/sync/args.rs index 0d0ca19d..28f7e271 100644 --- a/crates/radicle-cli/src/commands/sync/args.rs +++ b/crates/radicle-cli/src/commands/sync/args.rs @@ -4,14 +4,14 @@ use std::time; use clap::{Parser, Subcommand, ValueEnum}; use radicle::{ - node::{sync, NodeId}, + node::{NodeId, sync}, prelude::RepoId, storage::refs, }; use crate::common_args::{ - SignedReferencesFeatureLevel, SignedReferencesFeatureLevelParser, - ABOUT_FETCH_SIGNED_REFERENCES_FEATURE_LEVEL_MINIMUM, + ABOUT_FETCH_SIGNED_REFERENCES_FEATURE_LEVEL_MINIMUM, SignedReferencesFeatureLevel, + SignedReferencesFeatureLevelParser, }; use crate::node::SyncSettings; diff --git a/crates/radicle-cli/src/commands/unseed.rs b/crates/radicle-cli/src/commands/unseed.rs index 9bac3781..df9fdfd4 100644 --- a/crates/radicle-cli/src/commands/unseed.rs +++ b/crates/radicle-cli/src/commands/unseed.rs @@ -1,6 +1,6 @@ pub mod args; -use radicle::{prelude::*, Node}; +use radicle::{Node, prelude::*}; use crate::terminal as term; diff --git a/crates/radicle-cli/src/commands/watch.rs b/crates/radicle-cli/src/commands/watch.rs index bd72a33f..d1e8b021 100644 --- a/crates/radicle-cli/src/commands/watch.rs +++ b/crates/radicle-cli/src/commands/watch.rs @@ -2,7 +2,7 @@ mod args; use std::{thread, time}; -use anyhow::{anyhow, Context as _}; +use anyhow::{Context as _, anyhow}; use radicle::git; use radicle::git::raw::ErrorExt as _; diff --git a/crates/radicle-cli/src/git.rs b/crates/radicle-cli/src/git.rs index 7d688843..2144a03d 100644 --- a/crates/radicle-cli/src/git.rs +++ b/crates/radicle-cli/src/git.rs @@ -14,21 +14,21 @@ use std::path::{Path, PathBuf}; use std::process::Command; use std::str::FromStr; -use anyhow::anyhow; use anyhow::Context as _; +use anyhow::anyhow; use thiserror::Error; use radicle::crypto::ssh; use radicle::git; -use radicle::git::{Version, VERSION_REQUIRED}; +use radicle::git::{VERSION_REQUIRED, Version}; use radicle::prelude::{NodeId, RepoId}; use radicle::storage::git::transport; pub use radicle::git::Oid; pub use radicle::git::raw::{ - build::CheckoutBuilder, AnnotatedCommit, Commit, Direction, ErrorCode, ErrorExt as _, - MergeAnalysis, MergeOptions, Reference, Repository, Signature, + AnnotatedCommit, Commit, Direction, ErrorCode, ErrorExt as _, MergeAnalysis, MergeOptions, + Reference, Repository, Signature, build::CheckoutBuilder, }; pub const CONFIG_COMMIT_GPG_SIGN: &str = "commit.gpgsign"; diff --git a/crates/radicle-cli/src/git/ddiff.rs b/crates/radicle-cli/src/git/ddiff.rs index 7157beee..0938adb3 100644 --- a/crates/radicle-cli/src/git/ddiff.rs +++ b/crates/radicle-cli/src/git/ddiff.rs @@ -305,7 +305,7 @@ impl unified_diff::Decode for DiffModification { (v1, v2) => { return Err(unified_diff::Error::syntax(format!( "indicator character expected, but got '{v1}{v2}'" - ))) + ))); } }; diff --git a/crates/radicle-cli/src/git/pretty_diff.rs b/crates/radicle-cli/src/git/pretty_diff.rs index dc306b93..d7eaae92 100644 --- a/crates/radicle-cli/src/git/pretty_diff.rs +++ b/crates/radicle-cli/src/git/pretty_diff.rs @@ -7,8 +7,8 @@ use radicle_surf::diff; use radicle_surf::diff::{Added, Copied, Deleted, FileStats, Hunks, Modified, Moved}; use radicle_surf::diff::{Diff, DiffContent, FileDiff, Hunk, Modification}; use radicle_term as term; -use term::cell::Cell; use term::VStack; +use term::cell::Cell; use crate::git::unified_diff::FileHeader; use crate::terminal::highlight::{Highlighter, Theme}; diff --git a/crates/radicle-cli/src/git/unified_diff.rs b/crates/radicle-cli/src/git/unified_diff.rs index 3843d0eb..e4686841 100644 --- a/crates/radicle-cli/src/git/unified_diff.rs +++ b/crates/radicle-cli/src/git/unified_diff.rs @@ -533,7 +533,7 @@ impl Decode for Modification { Some(c) => { return Err(Error::syntax(format!( "indicator character expected, but got '{c}'", - ))) + ))); } None => return Err(Error::UnexpectedEof), }; diff --git a/crates/radicle-cli/src/main.rs b/crates/radicle-cli/src/main.rs index 5ebfff12..44213c67 100644 --- a/crates/radicle-cli/src/main.rs +++ b/crates/radicle-cli/src/main.rs @@ -5,8 +5,8 @@ use std::io::Write; use std::{io::ErrorKind, process}; use anyhow::anyhow; -use clap::builder::styling::AnsiColor; use clap::builder::Styles; +use clap::builder::styling::AnsiColor; use clap::{CommandFactory as _, Parser, Subcommand}; use radicle::version::Version; diff --git a/crates/radicle-cli/src/node.rs b/crates/radicle-cli/src/node.rs index ffef201f..5165c523 100644 --- a/crates/radicle-cli/src/node.rs +++ b/crates/radicle-cli/src/node.rs @@ -4,7 +4,7 @@ use std::io::Write; use radicle::node::sync; use radicle::node::{Handle as _, NodeId}; -use radicle::storage::{refs, ReadRepository, RepositoryError}; +use radicle::storage::{ReadRepository, RepositoryError, refs}; use radicle::{Node, Profile}; use crate::terminal as term; @@ -136,7 +136,9 @@ pub fn announce( match announce_(repo, settings, reporting, node, profile) { Ok(result) => Ok(result), Err(e) if e.is_connection_err() => { - term::hint("Node is stopped. To announce changes to the network, start it with `rad node start`."); + term::hint( + "Node is stopped. To announce changes to the network, start it with `rad node start`.", + ); Ok(None) } Err(e) => Err(e), diff --git a/crates/radicle-cli/src/terminal/args.rs b/crates/radicle-cli/src/terminal/args.rs index 71553104..d1e6e5ab 100644 --- a/crates/radicle-cli/src/terminal/args.rs +++ b/crates/radicle-cli/src/terminal/args.rs @@ -32,7 +32,9 @@ pub(crate) enum BlockTarget { } #[derive(Debug, Error)] -#[error("invalid repository or node specified (RID parsing failed with: '{repo}', NID parsing failed with: '{node}'))")] +#[error( + "invalid repository or node specified (RID parsing failed with: '{repo}', NID parsing failed with: '{node}'))" +)] pub(crate) struct BlockTargetParseError { repo: radicle::identity::IdError, node: radicle::crypto::PublicKeyError, @@ -62,7 +64,9 @@ impl std::fmt::Display for BlockTarget { } #[derive(Debug, thiserror::Error)] -#[error("invalid Node ID specified (Node ID parsing failed with: '{nid}', DID parsing failed with: '{did}'))")] +#[error( + "invalid Node ID specified (Node ID parsing failed with: '{nid}', DID parsing failed with: '{did}'))" +)] pub(crate) struct NodeIdParseError { did: radicle::identity::did::DidError, nid: radicle::crypto::PublicKeyError, diff --git a/crates/radicle-cli/src/terminal/cob.rs b/crates/radicle-cli/src/terminal/cob.rs index f2f2d250..81c4b20a 100644 --- a/crates/radicle-cli/src/terminal/cob.rs +++ b/crates/radicle-cli/src/terminal/cob.rs @@ -1,4 +1,5 @@ use radicle::{ + Profile, cob::{ self, cache::{MigrateCallback, MigrateProgress}, @@ -6,7 +7,6 @@ use radicle::{ prelude::NodeId, profile, storage::ReadRepository, - Profile, }; use radicle_term as term; diff --git a/crates/radicle-cli/src/terminal/comment.rs b/crates/radicle-cli/src/terminal/comment.rs index 8b9c88cb..b5d0dd1c 100644 --- a/crates/radicle-cli/src/terminal/comment.rs +++ b/crates/radicle-cli/src/terminal/comment.rs @@ -1,5 +1,5 @@ -use radicle::cob::thread::{Comment, CommentId}; use radicle::Profile; +use radicle::cob::thread::{Comment, CommentId}; use crate::terminal as term; use crate::terminal::format::Author; diff --git a/crates/radicle-cli/src/terminal/format.rs b/crates/radicle-cli/src/terminal/format.rs index f5b702f3..71b5e40f 100644 --- a/crates/radicle-cli/src/terminal/format.rs +++ b/crates/radicle-cli/src/terminal/format.rs @@ -3,14 +3,14 @@ use std::fmt; use localtime::LocalTime; pub use radicle_term::format::*; -pub use radicle_term::{style, Paint}; +pub use radicle_term::{Paint, style}; use radicle::cob::ObjectId; use radicle::identity::Visibility; use radicle::node::policy::Policy; use radicle::node::{Alias, AliasStore, NodeId}; use radicle::prelude::Did; -use radicle::profile::{env, Profile}; +use radicle::profile::{Profile, env}; use radicle::storage::RefUpdate; use radicle_term::element::Line; diff --git a/crates/radicle-cli/src/terminal/io.rs b/crates/radicle-cli/src/terminal/io.rs index e37d8b3d..3ba25c73 100644 --- a/crates/radicle-cli/src/terminal/io.rs +++ b/crates/radicle-cli/src/terminal/io.rs @@ -1,12 +1,12 @@ use anyhow::anyhow; +use radicle::cob::Reaction; use radicle::cob::issue::Issue; use radicle::cob::thread::{Comment, CommentId}; -use radicle::cob::Reaction; -use radicle::crypto::ssh::keystore::MemorySigner; use radicle::crypto::ssh::Keystore; +use radicle::crypto::ssh::keystore::MemorySigner; use radicle::node::device::{BoxedDevice, Device}; -use radicle::profile::env::RAD_PASSPHRASE; use radicle::profile::Profile; +use radicle::profile::env::RAD_PASSPHRASE; pub use radicle_term::io::*; pub use radicle_term::spinner; diff --git a/crates/radicle-cli/src/terminal/issue.rs b/crates/radicle-cli/src/terminal/issue.rs index d8dab198..94410f11 100644 --- a/crates/radicle-cli/src/terminal/issue.rs +++ b/crates/radicle-cli/src/terminal/issue.rs @@ -3,14 +3,14 @@ use std::io; use radicle_term::table::TableOptions; use radicle_term::{Table, VStack}; +use radicle::Profile; use radicle::cob; use radicle::cob::issue; use radicle::cob::issue::CloseReason; -use radicle::Profile; use crate::terminal as term; -use crate::terminal::format::Author; use crate::terminal::Element; +use crate::terminal::format::Author; pub const OPEN_MSG: &str = r#"