From 961301f643fa0611cb43693031a30edfef8e46fa Mon Sep 17 00:00:00 2001 From: Fintan Halpenny Date: Wed, 29 Oct 2025 13:04:26 +0000 Subject: [PATCH] cli/terminal: clean up args::Error type The other variants of `terminal::args::Error` were no longer used. The only variant required is `Error::WithHint`. The enum is also made private, since it is only used in this crate. --- crates/radicle-cli/src/terminal.rs | 3 ++- crates/radicle-cli/src/terminal/args.rs | 11 +---------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/crates/radicle-cli/src/terminal.rs b/crates/radicle-cli/src/terminal.rs index c43b0464..d6986170 100644 --- a/crates/radicle-cli/src/terminal.rs +++ b/crates/radicle-cli/src/terminal.rs @@ -1,6 +1,7 @@ pub mod args; -pub use args::Error; +pub(crate) use args::Error; + pub mod format; pub mod io; pub use io::signer; diff --git a/crates/radicle-cli/src/terminal/args.rs b/crates/radicle-cli/src/terminal/args.rs index e486582d..a2e17575 100644 --- a/crates/radicle-cli/src/terminal/args.rs +++ b/crates/radicle-cli/src/terminal/args.rs @@ -5,16 +5,7 @@ use radicle::node::policy::Scope; use radicle::prelude::{Did, NodeId, RepoId}; #[derive(thiserror::Error, Debug)] -pub enum Error { - /// If this error is returned from argument parsing, help is displayed. - #[error("help invoked")] - Help, - /// If this error is returned from argument parsing, the manual page is displayed. - #[error("help manual invoked")] - HelpManual { name: &'static str }, - /// If this error is returned from argument parsing, usage is displayed. - #[error("usage invoked")] - Usage, +pub(crate) enum Error { /// An error with a hint. #[error("{err}")] WithHint {