mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle: rename resolved to is_resolved 

The standard in the codebase for boolean methods is to prefix them
with `is_`.

Change `resolved` to `is_resolved`.

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
This commit is contained in:
Fintan Halpenny 2024-02-08 15:55:30 +00:00 committed by cloudhead
parent 25ff5876ec
commit a1b41542b8
No known key found for this signature in database
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
radicle-httpd/src/api/json.rs
View File

@ -213,7 +213,7 @@ fn issue_comment(id: &CommentId, comment: &Comment, aliases: &impl AliasStore) -
).collect::<Vec<_>>(), ).collect::<Vec<_>>(),
"timestamp": comment.timestamp().as_secs(), "timestamp": comment.timestamp().as_secs(),
"replyTo": comment.reply_to(), "replyTo": comment.reply_to(),
"resolved": comment.resolved(), "resolved": comment.is_resolved(),
}) })
} }
@ -235,7 +235,7 @@ fn patch_comment(
"timestamp": comment.timestamp().as_secs(), "timestamp": comment.timestamp().as_secs(),
"replyTo": comment.reply_to(), "replyTo": comment.reply_to(),
"location": comment.location(), "location": comment.location(),
"resolved": comment.resolved(), "resolved": comment.is_resolved(),
}) })
} }
@ -257,7 +257,7 @@ fn review_comment(
"timestamp": comment.timestamp().as_secs(), "timestamp": comment.timestamp().as_secs(),
"replyTo": comment.reply_to(), "replyTo": comment.reply_to(),
"location": comment.location(), "location": comment.location(),
"resolved": comment.resolved(), "resolved": comment.is_resolved(),
}) })
} }

2
radicle/src/cob/thread.rs
View File

@ -211,7 +211,7 @@ impl<L> Comment<L> {
} }
/// Get comment resolution status. /// Get comment resolution status.
pub fn resolved(&self) -> bool { pub fn is_resolved(&self) -> bool {
self.resolved self.resolved
} }