From b8502397a5656a85d1c9c99790f5b199085883df Mon Sep 17 00:00:00 2001 From: Fintan Halpenny Date: Sun, 1 Mar 2026 12:42:50 +0000 Subject: [PATCH] protocol/wire: Remove SignedRefs encoding/decoding The implementations for `Encode` and `Decode` for `SignedRefs` existed for when `SignedRefs` was communicated over the wire. This was traded for communicating `RefsAt` instead. So, these can safely be removed. --- crates/radicle-protocol/src/wire.rs | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/crates/radicle-protocol/src/wire.rs b/crates/radicle-protocol/src/wire.rs index 591e9a86..ab7d08ee 100644 --- a/crates/radicle-protocol/src/wire.rs +++ b/crates/radicle-protocol/src/wire.rs @@ -17,7 +17,7 @@ use bytes::{Buf, BufMut}; use cypheraddr::tor; -use radicle::crypto::{PublicKey, Signature, Unverified}; +use radicle::crypto::{PublicKey, Signature}; use radicle::git; use radicle::git::fmt; use radicle::git::raw; @@ -29,7 +29,6 @@ use radicle::node::Timestamp; use radicle::node::UserAgent; use radicle::storage::refs::Refs; use radicle::storage::refs::RefsAt; -use radicle::storage::refs::SignedRefs; use crate::bounded::BoundedVec; use crate::service::filter; @@ -489,24 +488,6 @@ impl Decode for filter::Filter { } } -impl Encode for SignedRefs { - fn encode(&self, buf: &mut impl BufMut) { - self.id.encode(buf); - self.refs.encode(buf); - self.signature.encode(buf); - } -} - -impl Decode for SignedRefs { - fn decode(buf: &mut impl Buf) -> Result { - let id = NodeId::decode(buf)?; - let refs = Refs::decode(buf)?; - let signature = Signature::decode(buf)?; - - Ok(Self::new(refs, id, signature)) - } -} - impl Encode for RefsAt { fn encode(&self, buf: &mut impl BufMut) { self.remote.encode(buf); @@ -597,8 +578,6 @@ mod tests { use qcheck_macros::quickcheck; use radicle::assert_matches; - use radicle::crypto::Unverified; - use radicle::storage::refs::SignedRefs; prop_roundtrip!(u16); prop_roundtrip!(u32); @@ -609,7 +588,6 @@ mod tests { prop_roundtrip!(RepoId); prop_roundtrip!(Refs); prop_roundtrip!((String, String), tuple); - prop_roundtrip!(SignedRefs, signed_refs); #[quickcheck] fn prop_string(input: String) -> qcheck::TestResult {