mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

e2e: Fix race condition in test_non_fastforward_identity_doc 

Fixes an intermittent failure caused by a race condition with background
gossip messages.

Previously Eve's `RefsAnnounced` message could be processed by Bob
after the test updated the identity document to include Alice-Laptop
as a delegate. This caused Bob to unexpectedly fetch the issue in the
background, failing the `!has_issue` assertion.

We now explicitly wait for Bob to receive Eve's announcement before
updating the identity document.
This commit is contained in:
Adrian Duke 2026-04-21 15:50:44 +01:00 committed by Fintan Halpenny
parent 802e4726e3
commit bdd991a5f1
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/radicle-node/src/tests/e2e.rs
View File

@ -1725,6 +1725,7 @@ fn test_non_fastforward_identity_doc() {
let mut alice = alice.spawn(); let mut alice = alice.spawn();
let mut alice_laptop = alice_laptop.spawn(); let mut alice_laptop = alice_laptop.spawn();
let mut bob = bob.spawn(); let mut bob = bob.spawn();
let bob_events = bob.handle.events();
let mut eve = eve.spawn(); let mut eve = eve.spawn();
let has_issue = |node: &NodeHandle<MockSigner>, issue: &cob::ObjectId| -> bool { let has_issue = |node: &NodeHandle<MockSigner>, issue: &cob::ObjectId| -> bool {
@ -1770,6 +1771,13 @@ fn test_non_fastforward_identity_doc() {
.unwrap(); .unwrap();
assert!(has_issue(&eve, &issue)); assert!(has_issue(&eve, &issue));
bob_events
.wait(
|e| matches!(e, Event::RefsAnnounced { nid, .. } if *nid == eve.id).then_some(()),
DEFAULT_TIMEOUT,
)
.unwrap();
// Alice updates the identity of the document to include her laptop // Alice updates the identity of the document to include her laptop
let (prev, next) = { let (prev, next) = {
let repo = alice.storage.repository(rid).unwrap(); let repo = alice.storage.repository(rid).unwrap();