mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radicle: fix cyphernet flag & update deps 

The `cyphernet` package has two feature flags that delegate to
underlying crates. These are:
* ed25519 = cyphergraphy/ed25519
* p2p-ed25519 = cypheraddr/p2p-ed25519

When attempting to install binaries, the compiler will result in an
error:
```
error[E0432]: unresolved import `cyphernet::addr::PeerAddr`
  --> radicle/src/node.rs:26:9
   |
26 | pub use cyphernet::addr::PeerAddr;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^ no `PeerAddr` in the root
```

The `PeerAddr` type is only exported when `p2p-ed25519` or
`cypheraddr/p2p-secp256k1` is enabled. The `radicle` crate was using
the `ed25519` flag. Instead, the `p2p-ed25519` flag should be used.

No explanation as to why the previous flag was working could be found,
but is being discussed on Zulip[[0]].

To update the dependencies, a `cargo update` was also excuted to
update the dependencies.

[0]: https://radicle.zulipchat.com/#narrow/stream/369277-heartwood/topic/cyphernet.20dubious.20feature.20flag

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
This commit is contained in:
Fintan Halpenny 2023-07-04 11:10:07 +01:00
parent 1a1e63d998
commit bed69ddca9
No known key found for this signature in database
GPG Key ID: 2552FB6F64066CB7
2 changed files with 332 additions and 394 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

724
Cargo.lock generated
View File

File diff suppressed because it is too large Load Diff

2
radicle/Cargo.toml
View File

@ -12,7 +12,7 @@ test = ["qcheck", "radicle-crypto/test"]
[dependencies]
amplify = { version = "4.0.0", default-features = false, features = ["std"] }
crossbeam-channel = { version = "0.5.6" }
cyphernet = { version = "0.2.0", features = ["tor", "dns", "ed25519"] }
cyphernet = { version = "0.2.0", features = ["tor", "dns", "p2p-ed25519"] }
fastrand = { version = "1.9.0" }
multibase = { version = "0.9.1" }
localtime = { version = "1.2.0", features = ["serde"] }