mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cob: Remove EntryId and RevisionId conversions 

Clippy warns that EntryId::from and RevisionId::from are not
required.

Remove the unecessary calls in radicle-cob and radicle.

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
This commit is contained in:
Fintan Halpenny 2023-09-05 16:40:18 +01:00 committed by cloudhead
parent 287a920d12
commit bf8cee2446
No known key found for this signature in database
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
radicle-cob/src/change_graph.rs
View File

@ -7,8 +7,8 @@ use git_ext::Oid;
use radicle_dag::Dag; use radicle_dag::Dag;
use crate::{ use crate::{
change, history::EntryId, object, signatures::ExtendedSignature, CollaborativeObject, Entry, change, object, signatures::ExtendedSignature, CollaborativeObject, Entry, History, ObjectId,
History, ObjectId, TypeName, TypeName,
}; };
/// The graph of changes for a particular collaborative object /// The graph of changes for a particular collaborative object
@ -102,10 +102,10 @@ impl ChangeGraph {
graph.node(id, entry); graph.node(id, entry);
for k in &change.dependents { for k in &change.dependents {
graph.dependency(EntryId::from(*k), id); graph.dependency(*k, id);
} }
for k in &change.dependencies { for k in &change.dependencies {
graph.dependency(id, EntryId::from(*k)); graph.dependency(id, *k);
} }
ControlFlow::Continue(graph) ControlFlow::Continue(graph)
}); });

2
radicle/src/cob/store.rs
View File

@ -367,7 +367,7 @@ impl<T: FromHistory> Transaction<T> {
object, object,
parents, parents,
} = store.update(id, msg, actions.clone(), self.embeds, signer)?; } = store.update(id, msg, actions.clone(), self.embeds, signer)?;
let id = EntryId::from(head); let id = head;
let author = self.actor; let author = self.actor;
let timestamp = Timestamp::from_secs(object.history().timestamp()); let timestamp = Timestamp::from_secs(object.history().timestamp());
let identity = store.identity; let identity = store.identity;