From c30f137bb126f97f90caa1bbf8d9462110e1f752 Mon Sep 17 00:00:00 2001
From: cloudhead <cloudhead@radicle.xyz>
Date: Thu, 3 Aug 2023 11:39:33 +0200
Subject: [PATCH] cli: Add `--timeout` and `--count` to `node events`

---
 radicle-cli/src/commands/node.rs        | 42 ++++++++++++++++++-------
 radicle-cli/src/commands/node/events.rs | 16 +++++++---
 radicle-cli/src/terminal/args.rs        |  8 +++++
 3 files changed, 49 insertions(+), 17 deletions(-)

diff --git a/radicle-cli/src/commands/node.rs b/radicle-cli/src/commands/node.rs
index 14b883a3..42827a4f 100644
--- a/radicle-cli/src/commands/node.rs
+++ b/radicle-cli/src/commands/node.rs
@@ -32,28 +32,33 @@ Usage
     rad node connect <nid>@<addr> [<option>...]
     rad node routing [--rid <rid>] [--nid <nid>] [--json] [<option>...]
     rad node tracking [--repos | --nodes] [<option>...]
-    rad node events [<option>...]
+    rad node events [--timeout <secs>] [-n <count>] [<option>...]
 
     For `<node-option>` see `radicle-node --help`.
 
 Start options
 
-    --foreground    Start the node in the foreground
+    --foreground         Start the node in the foreground
 
 Routing options
 
-    --rid <rid>     Show the routing table entries for the given RID
-    --nid <nid>     Show the routing table entries for the given NID
-    --json          Output the routing table as json
+    --rid <rid>          Show the routing table entries for the given RID
+    --nid <nid>          Show the routing table entries for the given NID
+    --json               Output the routing table as json
 
 Tracking options
 
-    --repos         Show the tracked repositories table
-    --nodes         Show the tracked nodes table
+    --repos              Show the tracked repositories table
+    --nodes              Show the tracked nodes table
+
+Events options
+
+    --timeout <secs>     How long to wait to receive an event before giving up
+    --count, -n <count>  Exit after <count> events
 
 General options
 
-    --help          Print help
+    --help               Print help
 "#,
 };
 
@@ -65,7 +70,10 @@ pub enum Operation {
     Connect {
         addr: PeerAddr<NodeId, Address>,
     },
-    Events,
+    Events {
+        timeout: time::Duration,
+        count: usize,
+    },
     Routing {
         json: bool,
         rid: Option<Id>,
@@ -119,6 +127,8 @@ impl Args for Options {
         let mut json: bool = false;
         let mut addr: Option<PeerAddr<NodeId, Address>> = None;
         let mut lines: usize = 10;
+        let mut count: usize = usize::MAX;
+        let mut timeout = time::Duration::MAX;
 
         while let Some(arg) = parser.next()? {
             match arg {
@@ -149,6 +159,14 @@ impl Args for Options {
                     nid = term::args::nid(&val).ok();
                 }
                 Long("json") if matches!(op, Some(OperationName::Routing)) => json = true,
+                Long("timeout") if matches!(op, Some(OperationName::Events)) => {
+                    let val = parser.value()?;
+                    timeout = term::args::seconds(&val)?;
+                }
+                Long("count") | Short('n') if matches!(op, Some(OperationName::Events)) => {
+                    let val = parser.value()?;
+                    count = term::args::number(&val)?;
+                }
                 Long("repos") if matches!(op, Some(OperationName::Tracking)) => {
                     tracking_mode = TrackingMode::Repos
                 }
@@ -174,7 +192,7 @@ impl Args for Options {
                     anyhow!("an address of the form `<nid>@<host>:<port>` must be provided")
                 })?,
             },
-            OperationName::Events => Operation::Events,
+            OperationName::Events => Operation::Events { timeout, count },
             OperationName::Routing => Operation::Routing { rid, nid, json },
             OperationName::Logs => Operation::Logs { lines },
             OperationName::Start => Operation::Start {
@@ -197,8 +215,8 @@ pub fn run(options: Options, ctx: impl term::Context) -> anyhow::Result<()> {
 
     match options.op {
         Operation::Connect { addr } => control::connect(&mut node, addr.id, addr.addr)?,
-        Operation::Events => {
-            events::run(node)?;
+        Operation::Events { timeout, count } => {
+            events::run(node, count, timeout)?;
         }
         Operation::Routing { rid, nid, json } => {
             let store =
diff --git a/radicle-cli/src/commands/node/events.rs b/radicle-cli/src/commands/node/events.rs
index 11a8c66d..7e822c64 100644
--- a/radicle-cli/src/commands/node/events.rs
+++ b/radicle-cli/src/commands/node/events.rs
@@ -2,12 +2,18 @@ use std::time;
 
 use radicle::node::Handle;
 
-pub fn run(node: impl Handle) -> anyhow::Result<()> {
-    let events = node.subscribe(time::Duration::MAX)?;
-    for event in events {
+pub fn run(node: impl Handle, count: usize, timeout: time::Duration) -> anyhow::Result<()> {
+    let events = node.subscribe(timeout)?;
+    for (i, event) in events.enumerate() {
         let event = event?;
-        let json_string = serde_json::to_string(&event)?;
-        println!("{json_string}");
+        let obj = serde_json::to_string(&event)?;
+
+        println!("{obj}");
+
+        // Only output up to `count` events.
+        if i + 1 >= count {
+            break;
+        }
     }
 
     Ok(())
diff --git a/radicle-cli/src/terminal/args.rs b/radicle-cli/src/terminal/args.rs
index c3e85de8..4b43bbe8 100644
--- a/radicle-cli/src/terminal/args.rs
+++ b/radicle-cli/src/terminal/args.rs
@@ -1,5 +1,6 @@
 use std::ffi::OsString;
 use std::str::FromStr;
+use std::time;
 
 use anyhow::anyhow;
 
@@ -132,6 +133,13 @@ pub fn number(val: &OsString) -> anyhow::Result<usize> {
     usize::from_str(&val).map_err(|_| anyhow!("invalid number '{}'", val))
 }
 
+pub fn seconds(val: &OsString) -> anyhow::Result<time::Duration> {
+    let val = val.to_string_lossy();
+    let secs = u64::from_str(&val).map_err(|_| anyhow!("invalid number of seconds '{}'", val))?;
+
+    Ok(time::Duration::from_secs(secs))
+}
+
 pub fn string(val: &OsString) -> String {
     val.to_string_lossy().to_string()
 }