mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fetch: clean up logging 

Evaluate the use of `warn!` and `error!` logging in `radicle-fetch`.

The majority are downgraded to `debug!`, the rest either being
downgraded to `info!` or removed altogether.
This commit is contained in:
Fintan Halpenny 2026-01-19 11:52:24 +00:00 committed by Lorenz Leutgeb
parent d860ec15b3
commit e3cb36d950
4 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/radicle-fetch/src/lib.rs
View File

@ -150,16 +150,11 @@ where
}
fn handle_handshake_err(err: handshake::Error) -> HandshakeError {
let err = match err {
match err {
handshake::Error::Transport(error) => match error {
gix_transport::client::Error::Io(error) => HandshakeError::Io(error),
err => HandshakeError::Gix(handshake::Error::Transport(err)),
},
err => {
log::warn!(target: "fetch", "Failed to perform handshake: {err}");
HandshakeError::Gix(err)
}
};
log::warn!(target: "fetch", "{err}");
err
err => HandshakeError::Gix(err),
}
}

6
crates/radicle-fetch/src/policy.rs
View File

@ -20,7 +20,7 @@ impl Allowed {
.map_err(|err| error::Policy::FailedPolicy { rid, err })?;
match entry.policy {
SeedingPolicy::Block => {
log::error!(target: "fetch", "Attempted to fetch non-seeded repo {rid}");
log::info!(target: "fetch", "Attempted to fetch non-seeded repo {rid}");
Err(error::Policy::BlockedPolicy { rid })
}
SeedingPolicy::Allow { scope: Scope::All } => Ok(Self::All),
@ -37,7 +37,7 @@ impl Allowed {
let node = match node {
Ok(policy) => policy,
Err(err) => {
log::error!(target: "fetch", "Failed to read follow policy for {rid}: {err}");
log::debug!(target: "fetch", "Failed to read follow policy for {rid}: {err}");
continue;
}
};
@ -81,7 +81,7 @@ impl BlockList {
let entry = match entry {
Ok(entry) => entry,
Err(err) => {
log::error!(target: "fetch", "Failed to read follow policy: {err}");
log::debug!(target: "fetch", "Failed to read follow policy: {err}");
continue;
}
};

6
crates/radicle-fetch/src/state.rs
View File

@ -443,7 +443,7 @@ impl FetchState {
match handle.transport.done() {
Ok(()) => log::debug!(target: "fetch", "Sent done signal to remote {remote}"),
Err(err) => {
log::warn!(target: "fetch", "Attempted to send done to remote {remote}: {err}")
log::debug!(target: "fetch", "Failed to signal EOF to {remote}: {err}")
}
}
@ -485,7 +485,7 @@ impl FetchState {
self.prune(&remote);
}
sigrefs::DelegateStatus::Delegate { remote, data: None } => {
log::warn!(target: "fetch", "Pruning delegate {remote} tips, missing 'rad/sigrefs'");
log::debug!(target: "fetch", "Pruning delegate {remote} tips, missing 'rad/sigrefs'");
failures.push(sigrefs::Validation::MissingRadSigRefs(remote));
self.prune(&remote);
// This delegate has removed their `rad/sigrefs`.
@ -552,7 +552,7 @@ impl FetchState {
let mut fails =
sigrefs::validate(&cache, sigrefs)?.unwrap_or(Validations::default());
if !fails.is_empty() {
log::warn!(target: "fetch", "Pruning delegate {remote} tips, due to validation failures");
log::debug!(target: "fetch", "Pruning delegate {remote} tips, due to validation failures");
self.prune(&remote);
valid_delegates.remove(&remote);
failed_delegates.insert(remote);

4
crates/radicle-fetch/src/transport.rs
View File

@ -328,8 +328,8 @@ fn agent_name() -> String {
Ok(version) => version,
Err(err) => {
use radicle::git::VERSION_REQUIRED;
log::warn!(target: "fetch", "The git version could not be determined: {err}");
log::warn!(target: "fetch", "Pretending that we are on git version {VERSION_REQUIRED}.");
log::debug!(target: "fetch", "The git version could not be determined: {err}");
log::debug!(target: "fetch", "Pretending that we are on git version {VERSION_REQUIRED}.");
VERSION_REQUIRED
}
};