From ebee41fbf12255b2b9699c9fb68bebf90553e9f0 Mon Sep 17 00:00:00 2001
From: cloudhead <cloudhead@radicle.xyz>
Date: Mon, 11 Dec 2023 13:33:05 +0100
Subject: [PATCH] cli: Only allow shell-friendly characters in names

---
 radicle-cli/src/commands/init.rs | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/radicle-cli/src/commands/init.rs b/radicle-cli/src/commands/init.rs
index 7aa9b493..2a551eb6 100644
--- a/radicle-cli/src/commands/init.rs
+++ b/radicle-cli/src/commands/init.rs
@@ -84,13 +84,21 @@ impl Args for Options {
         while let Some(arg) = parser.next()? {
             match arg {
                 Long("name") if name.is_none() => {
-                    let value = parser
-                        .value()?
-                        .to_str()
-                        .ok_or(anyhow::anyhow!(
-                            "invalid project name specified with `--name`"
-                        ))?
-                        .to_owned();
+                    let value = parser.value()?;
+                    let value = term::args::string(&value);
+                    let allowed = ['-', '_', '.'];
+
+                    // Nb. We avoid characters that need to be quoted by shells, such as `$`,
+                    // `!` etc., since repository names are used for naming folders during clone.
+                    if !value
+                        .chars()
+                        .all(|c| c.is_alphanumeric() || allowed.contains(&c))
+                    {
+                        anyhow::bail!(
+                            "invalid project name specified with `--name`, \
+                            only alphanumeric characters, '-', '_' and '.' are allowed"
+                        );
+                    }
                     name = Some(value);
                 }
                 Long("description") if description.is_none() => {