From f6bf13422d3fbff6f83e32ad892f2fe559a754e2 Mon Sep 17 00:00:00 2001 From: Adrian Duke Date: Thu, 16 Apr 2026 13:59:36 +0100 Subject: [PATCH] just: Fix doublestar expansion in check-scripts --- justfile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/justfile b/justfile index 5a73590d..35441d45 100644 --- a/justfile +++ b/justfile @@ -66,6 +66,10 @@ check-spelling: (verify-tool "codespell") @echo "{{CHECK}}Checking for code typos...{{NORMAL}}" @git ls-files -z | xargs -0 codespell --write-changes --check-filenames +# just runs with `/bin/sh` which has no doublestar glob +# expansion, furthermore, `time ls **/*.sh` takes ~5s +# locally. The `find` solution below is fastest ~900ms. +# # Run shellcheck on all shell scripts [group('pre-commit')] [group('pre-push')] @@ -73,7 +77,7 @@ check-spelling: (verify-tool "codespell") [parallel] check-scripts: (verify-tool "shellcheck") @echo "{{CHECK}}Checking shell scripts...{{NORMAL}}" - @shellcheck **/*.sh + @find . -type f -name "*.sh" -exec shellcheck {} + # Run checks for forbidden keywords [group('pre-commit')]