mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

e2e: improve flake in missing_delegate_default_branch 

The `missing_delegate_default_branch` test was flakey and would fail checking if
Bob had the `rid` in storage.

This can be improved by waiting to ensure that Bob has a `RefsFetched` event
before performing the check.
This commit is contained in:
Fintan Halpenny 2024-11-11 09:39:53 +00:00 committed by cloudhead
parent 0d402647cb
commit f9c3523183
No known key found for this signature in database
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
radicle-node/src/tests/e2e.rs
View File

@ -1229,6 +1229,8 @@ fn missing_delegate_default_branch() {
let mut bob = bob.spawn(); let mut bob = bob.spawn();
let mut seed = seed.spawn(); let mut seed = seed.spawn();
let bob_events = bob.handle.events();
alice.handle.seed(rid, Scope::All).unwrap(); alice.handle.seed(rid, Scope::All).unwrap();
bob.handle.seed(rid, Scope::All).unwrap(); bob.handle.seed(rid, Scope::All).unwrap();
seed.handle.seed(rid, Scope::All).unwrap(); seed.handle.seed(rid, Scope::All).unwrap();
@ -1237,6 +1239,15 @@ fn missing_delegate_default_branch() {
bob.connect(&seed); bob.connect(&seed);
bob.handle.fetch(rid, seed.id, DEFAULT_TIMEOUT).unwrap(); bob.handle.fetch(rid, seed.id, DEFAULT_TIMEOUT).unwrap();
bob_events
.wait(
|e| {
matches!(e, service::Event::RefsFetched { updated, .. } if !updated.is_empty())
.then_some(())
},
DEFAULT_TIMEOUT,
)
.unwrap();
assert!(bob.storage.contains(&rid).unwrap()); assert!(bob.storage.contains(&rid).unwrap());
// Helper to assert that Bob's default branch is not in storage // Helper to assert that Bob's default branch is not in storage
@ -1291,7 +1302,7 @@ fn missing_delegate_default_branch() {
&radicle::cob::issue::TYPENAME, &radicle::cob::issue::TYPENAME,
&issue, &issue,
); );
assert!(repo.backend.find_reference(issue_ref.as_str()).is_ok()); assert!(repo.backend.find_reference(issue_ref.as_str()).is_ok(),);
}; };
// The seed fetches from Bob and checks that: // The seed fetches from Bob and checks that: