14 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
Fintan Halpenny
|
ab3621d5d4 | ||
Lorenz Leutgeb
|
94f65a71db | ||
|
Fintan Halpenny
|
597b514d6c | ||
|
Fintan Halpenny
|
9fd4f00c23 | ||
|
Fintan Halpenny
|
d5fea6324c | ||
|
Lorenz Leutgeb
|
b7cfcfff75 |
Make `git2` an *optional* dependency of `radicle-cob`, and refactor
`radicle` to depend on crates that in turn do not depend on `git2`
*non-optionally*
The main offending dependency of `radicle-cob` is `radicle-git-ext`
from the `radicle-git` workspace in repository
(rad:z6cFWeWpnZNHh9rUW8phgA3b5yGt) which *non-optionally* depends on
`git2`.
So, to achieve removal of this dependency:
1. The crate is refactored to depend on the new crates
`radicle-git-ref-format` `radicle-git-metadata`, and
`radicle-oid` introduced in the previous commits, instead of
`radicle-git-ext`.
2. Some code from the `radicle-git-ext` crate in the `radicle-git`
workspace in repository (rad:z6cFWeWpnZNHh9rUW8phgA3b5yGt) is
copied. See `crates/radicle-cob/src/backend/git/commit.rs`.
This cascades to `radicle` and its dependents.
Firstly, the there is an
`impl Deref<Target=git2::Oid> for radicle_git_ext::Oid`. This made
it very convenient to just deref to obtain the wrapped `git2::Oid`,
so there are many expressions of the shape `*oid` in `radicle` and
its dependents. However `radicle-oid` does not provide
`impl Deref<Target=git2::Oid> for radicle_oid::Oid`, as notably,
`Target` is an associated type, and not a type parameter, so an
implementation of `Deref` would tie the new `Oid` too tightly to a
particular implementation.
Instead, work with `impl From<radicle_oid::Oid> for git2::Oid`
(which can be enabled using the feature flag `radicle-oid/git2`).
This explains the changes from `*oid` to `oid.into()` at every
transition to "`git2` land".
Secondly, `radicle` and its dependents are refactored to also depend
on `radicle-git-ref-format` and (much less prominently)
`radicle-git-metadata` instead of `radicle-git-ext`
This is to avoid pulling in `git2` via these dependencies.
Thirdly, as the re-exports in `crates/radicle/src/git.rs` change,
they are at the same time also cleaned up. Notably, the types from
`radicle-git-ref-format` are re-exported under `fmt` only, not "twice".
While overall this obviously is very much a breaking change, these
changes should mostly amount to changing from `Deref` to `Into`, i.e.,
`*oid` → `oid.into()` and rewriting imports for `radicle:
|
|
|
Fintan Halpenny
|
ee041d8d06 | ||
|
Lorenz Leutgeb
|
897404164b | ||
|
Fintan Halpenny
|
bbd1e2cff6 | ||
|
Lorenz Leutgeb
|
5229fb8a59 | ||
|
Fintan Halpenny
|
0e48723b41 | ||
|
Lorenz Leutgeb
|
d7b48b9e29 | ||
|
Fintan Halpenny
|
b77809ae9d | ||
|
Lorenz Leutgeb
|
5bc2dc677b |
Renamed from radicle-remote-helper/Cargo.toml (Browse further)