9 Commits

Author	SHA1	Message	Date
Lorenz Leutgeb	a1fa38018e	protocol: Depend on `cypheraddr` not `cyphernet` ... `radicle-protocol` depends on `cyphernet`, but only uses the module `cyphernet::addr`, which is a re-export of `cypheraddr`, which is unnecessary (as `cypheraddr` alone would do), and invites accidentally pulling in more dependencies via `cyphernet`. To prevent accidentally depending on further types from `cyphernet`, change this to more conservativeley depend on `cypheraddr`.	2026-02-16 09:43:38 +00:00
Lorenz Leutgeb	b7cfcfff75	workspace: A Little Less `git2` ... Make `git2` an *optional* dependency of `radicle-cob`, and refactor `radicle` to depend on crates that in turn do not depend on `git2` *non-optionally* The main offending dependency of `radicle-cob` is `radicle-git-ext` from the `radicle-git` workspace in repository (rad:z6cFWeWpnZNHh9rUW8phgA3b5yGt) which *non-optionally* depends on `git2`. So, to achieve removal of this dependency: 1. The crate is refactored to depend on the new crates `radicle-git-ref-format` `radicle-git-metadata`, and `radicle-oid` introduced in the previous commits, instead of `radicle-git-ext`. 2. Some code from the `radicle-git-ext` crate in the `radicle-git` workspace in repository (rad:z6cFWeWpnZNHh9rUW8phgA3b5yGt) is copied. See `crates/radicle-cob/src/backend/git/commit.rs`. This cascades to `radicle` and its dependents. Firstly, the there is an `impl Deref<Target=git2::Oid> for radicle_git_ext::Oid`. This made it very convenient to just deref to obtain the wrapped `git2::Oid`, so there are many expressions of the shape `*oid` in `radicle` and its dependents. However `radicle-oid` does not provide `impl Deref<Target=git2::Oid> for radicle_oid::Oid`, as notably, `Target` is an associated type, and not a type parameter, so an implementation of `Deref` would tie the new `Oid` too tightly to a particular implementation. Instead, work with `impl From<radicle_oid::Oid> for git2::Oid` (which can be enabled using the feature flag `radicle-oid/git2`). This explains the changes from `*oid` to `oid.into()` at every transition to "`git2` land". Secondly, `radicle` and its dependents are refactored to also depend on `radicle-git-ref-format` and (much less prominently) `radicle-git-metadata` instead of `radicle-git-ext` This is to avoid pulling in `git2` via these dependencies. Thirdly, as the re-exports in `crates/radicle/src/git.rs` change, they are at the same time also cleaned up. Notably, the types from `radicle-git-ref-format` are re-exported under `fmt` only, not "twice". While overall this obviously is very much a breaking change, these changes should mostly amount to changing from `Deref` to `Into`, i.e., `*oid` → `oid.into()` and rewriting imports for `radicle::fmt`. This is indicated by the mostly mechanical nature of the changes to `crates/radicle-{cli,node,remote-helper}`.	2025-10-13 16:14:23 +02:00
Lorenz Leutgeb	ded0d19d59	protocol/wire/test: Define `fn roundtrip` and macro ... In many tests we assert that encoding and decoding gives the same object. Let's call that a "roundrip", and also provide a proc macro to generate such tests.	2025-08-27 12:48:11 +02:00
Lorenz Leutgeb	a568e7f484	protocol: Refactor decoding ... Remove `fn deserialize` and instead provide a trait `fn decode_exact` for testing. Refactor errors, so that we can now cleanly distinguish between `Error::UnexpectedEnd` which means that decoding might work given more data, and `Error::Invalid`, which means that no amount of additional data will decode. While at it, cleanup the variants of `Error::Invalid`, and provide `ControlType`.	2025-08-25 11:57:44 +01:00
Lorenz Leutgeb	cbd2a7070c	protocol: Refactor encoding ... What made the issue fixed in the parent commit harder to spot for me was the multitude of concepts and terms involved in encoding: What's *serializing* vs. *encoding*? Why is there this odd `Frame::to_bytes`? So I decided to clean up a bit. I removed `fn serialize` so that the logic stays close to the data, and instead of it provide `fn encode_vec` in `trait Encode` so that we don't add up with one-offs like `Frame::to_bytes` again. Also we make use of `encode_vec` in the tests.	2025-08-25 11:57:44 +01:00
Lorenz Leutgeb	a8426dfdac	protocol: Fix panic when serializing large frames ... In 3c5668edd2 I mistakenly moved the check the length of an encoded `wire::Message` from its `impl wire::Encode` to the `fn serialize`, so that it would not apply only to messages (as originally intended), but to *any* argument of `serialize`. This is not a problem for gossip messages, but catastrophic for Git streams, which tend to send a lot of data. The fix is simple: Move the check back into `impl Encode for Message`.	2025-08-25 11:57:44 +01:00
Lorenz Leutgeb	3c5668edd2	protocol: Reimplement encoding on top of `bytes`	2025-07-16 21:15:55 +02:00
Lorenz Leutgeb	1c20f64a26	node, protocol: Refactor ... Mostly changes of `use`s and moving components to `radicle-protocol`, with the goal of just getting `radicle-node` to work on top of the new `radicle-protocol` crate.	2025-07-16 21:15:52 +02:00
Lorenz Leutgeb	61c468778a	protocol: Create skeleton by moving from radicle-node ... This commit will not build. If you are reading this while bisecting, please skip this commit. It is not fixed to build to get clean renames.	2025-07-16 21:12:42 +02:00

Renamed from crates/radicle-node/src/wire.rs (Browse further)