From e1c602d01abce8e1d0b98a28f7735aa794e771b9 Mon Sep 17 00:00:00 2001 From: iuvbio Date: Sun, 23 Feb 2020 17:24:08 +0100 Subject: [PATCH] if sheet does not exist, raise KeyError instead of ValueError --- pandas_ods_reader/parser.py | 2 +- tests/test_read_ods.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas_ods_reader/parser.py b/pandas_ods_reader/parser.py index 9aa7f65..13522ff 100644 --- a/pandas_ods_reader/parser.py +++ b/pandas_ods_reader/parser.py @@ -14,7 +14,7 @@ def load_ods(doc, sheet_id, headers=True, columns=None): if isinstance(sheet_id, str): sheets = [sheet.name for sheet in doc.sheets] if sheet_id not in sheets: - raise ValueError("There is no sheet named {}".format(sheet_id)) + raise KeyError("There is no sheet named {}".format(sheet_id)) sheet_id = sheets.index(sheet_id) + 1 sheet = doc.sheets[sheet_id - 1] df_dict = OrderedDict() diff --git a/tests/test_read_ods.py b/tests/test_read_ods.py index f99d283..c7b1d6f 100644 --- a/tests/test_read_ods.py +++ b/tests/test_read_ods.py @@ -107,7 +107,7 @@ class TestOdsReader: path = rsc / header_file sheet_name = "No_Sheet" - with pytest.raises(ValueError) as e_info: + with pytest.raises(KeyError) as e_info: read_ods(path, sheet_name) assert e_info.match(f"There is no sheet named {sheet_name}")