mab122
/
radicle-heartwood-lfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cli/patch/review: Obsoletion Warning 

As discussed in:
<https://radicle.zulipchat.com/#narrow/channel/369873-Support/topic/new.20to.20reviewing.20patches/with/533862639>
This commit is contained in:
Lorenz Leutgeb 2025-09-17 08:56:58 +02:00 committed by Fintan Halpenny
parent 8dd17e2a60
commit 7b00bf2e3a
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- The option `rad self --nid` was deprecated in favor of `rad status --only nid` - The option `rad self --nid` was deprecated in favor of `rad status --only nid`
- `rad diff` was deprecated in favor of using `git diff` - `rad diff` was deprecated in favor of using `git diff`
- `rad patch review --patch` and `rad patch review --delete` are made obsolete.
This functionality never worked as intended, and may be removed before the
next major release.
## New Features ## New Features

2
crates/radicle-cli/src/commands/patch/review.rs
View File

@ -83,6 +83,7 @@ pub fn run(
unified, unified,
hunk, hunk,
} if by_hunk => { } if by_hunk => {
crate::warning::obsolete("rad patch review --patch");
let mut opts = git::raw::DiffOptions::new(); let mut opts = git::raw::DiffOptions::new();
opts.patience(true) opts.patience(true)
.minimal(true) .minimal(true)
@ -124,6 +125,7 @@ pub fn run(
} }
} }
Operation::Delete => { Operation::Delete => {
crate::warning::obsolete("rad patch review --delete");
let name = git::refs::storage::draft::review(profile.id(), &patch_id); let name = git::refs::storage::draft::review(profile.id(), &patch_id);
match repository.backend.find_reference(&name) { match repository.backend.find_reference(&name) {