3.1 KiB
3.1 KiB
Merging patches into the wrong branch
First, we update the identity document to add a canonical reference rule for a new accepted branch.
$ rad id update --title "Add accepted branch" --payload xyz.radicle.crefs rules '{ "refs/heads/accepted": { "threshold": 1, "allow": "delegates" } }' -q
[..]
Now, let's create the accepted branch and push it:
$ git checkout -b accepted
Switched to a new branch 'accepted'
$ git commit --allow-empty -m "Initialize accepted branch"
[accepted [..]] Initialize accepted branch
$ git push rad accepted
✓ Canonical reference refs/heads/accepted updated to target commit [..]
To rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
* [new branch] accepted -> accepted
Next, we create a feature branch and open a patch targeting accepted.
$ git checkout -b feature/1
Switched to a new branch 'feature/1'
$ touch FEATURE.md
$ git add FEATURE.md
$ git commit -m "Add new feature"
[feature/1 [..]] Add new feature
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 FEATURE.md
$ git push -o patch.message="Add new feature" -o patch.target="refs/heads/accepted" rad HEAD:refs/patches
✓ Patch [..] opened
To rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
* [new reference] HEAD -> refs/patches
Now, Alice accidentally merges the feature into the master branch instead of accepted.
$ git checkout master
Switched to branch 'master'
$ git merge feature/1
Updating [..]
Fast-forward
FEATURE.md | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 FEATURE.md
$ git push rad master
✓ Canonical reference refs/heads/master updated to target commit [..]
To rad://z42hL2jL4XNk6K8oHQaSWfMgCL7ji/z6MknSLrJoTcukLrE435hVNQT4JUhbvWLX4kUzqkEStBU8Vi
[..]..[..] master -> master
Because the patch was explicitly targeted for accepted, it should remain open.
$ rad patch list --merged
Nothing to show.
$ rad patch list --open
╭───────────────────────────────────────────────────────────────────────────────────────╮
│ ● ID Title Author Reviews Head + - Updated Labels │
├───────────────────────────────────────────────────────────────────────────────────────┤
│ ● [.. ] Add new feature alice (you) - [.. ] +0 -0 now │
╰───────────────────────────────────────────────────────────────────────────────────────╯